diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 1febce98..6c74c1d4 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -19,7 +19,6 @@ jobs: - "3.2" - "3.3" rails: - - rails_61 - rails_70 - rails_71 - rails_72 diff --git a/CHANGELOG.md b/CHANGELOG.md index ef0adeee..0d4d959b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,242 +2,247 @@ ## Unreleased +* Remove support for Ruby `< 3.1` +* Remove support for Rails `< 7.0` +* Test against Rails 8.0 + ## Version 2.0.1 -* Prefer `require_relative` for internal requires [#939][]. +* Prefer `require_relative` for internal requires [#939][] ## Version 2.0.0 -* Test against Rails 7.2 [#921][]. -* Add frozen string literal to `InheritedResources` module [#933][]. -* Change return codes to new Responders defaults [#918][]. +* Test against Rails 7.2 [#921][] +* Add frozen string literal to `InheritedResources` module [#933][] +* Change return codes to new Responders defaults [#918][] ## Version 1.14.0 -* Remove upper bound dependency limits from gemspec. -* Allow using Rails 7.1 [#873][]. -* Remove support for Ruby `< 2.6`. +* Remove upper bound dependency limits from gemspec +* Allow using Rails 7.1 [#873][] +* Remove support for Ruby `< 2.6` ## Version 1.13.1 -* Allow using Rails 7.0. +* Allow using Rails 7.0 ## Version 1.13.0 -* Remove support for Ruby `< 2.5`. -* Coerce `:route_prefix` config option to a Symbol, ensuring compatibility with Rails versions that have resolved CVE-2021-22885. +* Remove support for Ruby `< 2.5` +* Coerce `:route_prefix` config option to a Symbol, ensuring compatibility with Rails versions that have resolved CVE-2021-22885 ## Version 1.12.0 -* Remove support for Rails 5.0 and Rails 5.1. -* Allow using Rails 6.1. +* Remove support for Rails 5.0 and Rails 5.1 +* Allow using Rails 6.1 ## Version 1.11.0 -* Add support for responders `>= 3.0`. -* Remove support for Ruby `< 2.4`. +* Add support for responders `>= 3.0` +* Remove support for Ruby `< 2.4` ## Version 1.10.0 -_No changes_. +_No changes_ ## Version 1.10.0.rc1 -* Preliminary support for Rails 6.0. -* Remove support for Rails 4.2. +* Preliminary support for Rails 6.0 +* Remove support for Rails 4.2 ## Version 1.9.0 -* Support Rails 5.2.1. -* Remove support for Ruby `< 2.3`. +* Support Rails 5.2.1 +* Remove support for Ruby `< 2.3` ## Version 1.8.0 -* Support Rails 5.2. -* Supports Ruby 2.4. -* Remove support for Ruby `< 2.2`, and Rails `< 4.2`. -* Fixed broken class name in belongs_to. -* Remove use of HttpCacheResponder. -* Correct request_name in isolated engines. -* Fix nested controllers and singleton option. +* Support Rails 5.2 +* Supports Ruby 2.4 +* Remove support for Ruby `< 2.2`, and Rails `< 4.2` +* Fixed broken class name in belongs_to +* Remove use of HttpCacheResponder +* Correct request_name in isolated engines +* Fix nested controllers and singleton option ## Version 1.7.2 -* Support Rails 5.1. +* Support Rails 5.1 ## Version 1.7.1 -* Fix regression with `get_resource_ivar` that was returning `false` instead of `nil` when the value was not set. -* Do not load `ActionController::Base` on boot time. +* Fix regression with `get_resource_ivar` that was returning `false` instead of `nil` when the value was not set +* Do not load `ActionController::Base` on boot time ## Version 1.7.0 -* Support Rails 5. -* Remove support for Ruby `< 2.1`. -* Fix URL helpers on mountable engines. -* Allow support to has_scope `< 0.6` and `> 1.0`. Users are now able to choose which version they want to use in their applications. +* Support Rails 5 +* Remove support for Ruby `< 2.1` +* Fix URL helpers on mountable engines +* Allow support to has_scope `< 0.6` and `> 1.0`. Users are now able to choose which version they want to use in their applications ## Version 1.6.0 -* Support Rails 4.2. +* Support Rails 4.2 ## Version 1.5.1 -* Lock the Rails version until only 4.2. -* Fix parent class lookup. -* Fix resource_class default value definition. +* Lock the Rails version until only 4.2 +* Fix parent class lookup +* Fix resource_class default value definition ## Version 1.5.0 -* Supports nested modules (namespaced models and controllers). -* Supports Rails 4 Strong Parameters notation. +* Supports nested modules (namespaced models and controllers) +* Supports Rails 4 Strong Parameters notation ## Version 1.4.1 -* Supports Rails 4. -* Improved compatibility with strong params. +* Supports Rails 4 +* Improved compatibility with strong params ## Version 1.4.0 -* Supports Ruby 2.0.0. -* Added support for the strong_parameters gem. See the README for more. -* Added the ability to pass without_protection when creating/updating. -* Fixed multi-level nested singletons. -* Correct paths now generated for uncountable shallow resources. +* Supports Ruby 2.0.0 +* Added support for the strong_parameters gem. See the README for more +* Added the ability to pass without_protection when creating/updating +* Fixed multi-level nested singletons +* Correct paths now generated for uncountable shallow resources ## Version 1.3.1 -* Fix polymorphic_belongs_to to get the parent. -* Added support for Rails 3.2. -* Added support to responders >= 0.6.0. +* Fix polymorphic_belongs_to to get the parent +* Added support for Rails 3.2 +* Added support to responders >= 0.6.0 ## Version 1.3.0 -* Added support for multiple polymorphic optional nesting. -* Fix nested namespace in mountable apps. -* Added support for rails 3.1 new mass assignment conventions. -* Turn InheritedResources::Base into a reloadable constant to fix reloading issues. +* Added support for multiple polymorphic optional nesting +* Fix nested namespace in mountable apps +* Added support for rails 3.1 new mass assignment conventions +* Turn InheritedResources::Base into a reloadable constant to fix reloading issues ## Version 1.2.2 -* Fix a bug in params parsing. -* Call .scoped only if it is available. +* Fix a bug in params parsing +* Call .scoped only if it is available ## Version 1.2.1 -* Fix a bug with namespaces. -* Use Post.scoped instead of Post.all in collection. +* Fix a bug with namespaces +* Use Post.scoped instead of Post.all in collection ## Version 1.2 -* Improved lookup for namespaces (by github.com/Sirupsen). -* Support to custom actions (by github.com/lda). -* Rails 3.1 compatibility (by github.com/etehtsea). +* Improved lookup for namespaces (by github.com/Sirupsen) +* Support to custom actions (by github.com/lda) +* Rails 3.1 compatibility (by github.com/etehtsea) ## Version 1.1 -* Rails 3 compatible. +* Rails 3 compatible ## Version 1.0 -* responders was removed from InheritedResources core and is a dependency. To install it, please do: +* responders was removed from InheritedResources core and is a dependency. To install it, please do sudo gem install responders -* has_scope was removed from InheritedResources core and is now available as a standalone gem. +* has_scope was removed from InheritedResources core and is now available as a standalone gem - To install it, please do: + To install it, please do sudo gem install has_scope ## Version 0.9 -* Allow dual blocks in destroy. -* Added :if and :unless to has_scope (thanks to Jack Danger). -* Added create_resource, update_resource and delete_resource hooks (thanks to Carlos Antonio da Silva). -* Backported ActionController::Responder from Rails 3. -* Added parent_url helper. -* Added association_chain helper (as suggested by https://github.com/emmanuel). +* Allow dual blocks in destroy +* Added :if and :unless to has_scope (thanks to Jack Danger) +* Added create_resource, update_resource and delete_resource hooks (thanks to Carlos Antonio da Silva) +* Backported ActionController::Responder from Rails 3 +* Added parent_url helper +* Added association_chain helper (as suggested by https://github.com/emmanuel) ## Version 0.8 -* Fixed a small bug on optional belongs to with namespaced controllers. -* Allow a parameter to be given to collection_url in polymorphic cases to replace the parent. -* Allow InheritedResources to be called without inheritance. -* Ensure that controllers that inherit from a controller with InheritedResources works properly. +* Fixed a small bug on optional belongs to with namespaced controllers +* Allow a parameter to be given to collection_url in polymorphic cases to replace the parent +* Allow InheritedResources to be called without inheritance +* Ensure that controllers that inherit from a controller with InheritedResources works properly ## Version 0.7 -* Allow procs as default value in has scope to be able to use values from session, for example. -* Allow blocks with arity 0 or -1 to be given as the redirect url: +* Allow procs as default value in has scope to be able to use values from session, for example +* Allow blocks with arity 0 or -1 to be given as the redirect url def destroy destroy!{ project_url(@project) } end -* Allow interpolation_options to be set in the application controller. -* Added has_scope to controller (an interface for named_scopes). -* Added polymorphic_belongs_to, optional_belongs_to and singleton_belongs_to as quick methods. -* Only load belongs_to, singleton and polymorphic helpers if they are actually required. base_helpers, class_methods, dumb_responder and url_helpers are loaded when you inherited from base for the first time. +* Allow interpolation_options to be set in the application controller +* Added has_scope to controller (an interface for named_scopes) +* Added polymorphic_belongs_to, optional_belongs_to and singleton_belongs_to as quick methods +* Only load belongs_to, singleton and polymorphic helpers if they are actually required. base_helpers, class_methods, dumb_responder and url_helpers are loaded when you inherited from base for the first time # Version 0.6 -* Ensure that the default template is not rendered if the default_template_format is not accepted. This is somehow related with the security breach report: +* Ensure that the default template is not rendered if the default_template_format is not accepted. This is somehow related with the security breach report https://rorsecurity.info/journal/2009/4/24/hidden-actions-render-templates.html IR forbids based on mime types. For example: respond_to :html, :except => :index ensures that the index.html.erb view is not rendered, making your IR controllers safer. -* Fixed a bug that happens only when format.xml is given to blocks and then it acts as default, instead of format.html. -* Fixed a strange bug where when you have create.html.erb or update.html.erb, it makes IE6 and IE7 return unprocessable entity (because they send Mime::ALL). -* Stop rescuing any error when constantizing the resource class and allow route_prefix to be nil. -* Cleaned up tests and responder structure. Whenever you pass a block to aliases and this block responds to the request, the other blocks are not parsed improving performance. -* [BACKWARDS INCOMPATIBLE] By default, Inherited Resources respond only :html requests. -* Added a quick way to overwrite the redirect to url in :create, :update and :destroy. +* Fixed a bug that happens only when format.xml is given to blocks and then it acts as default, instead of format.html +* Fixed a strange bug where when you have create.html.erb or update.html.erb, it makes IE6 and IE7 return unprocessable entity (because they send Mime::ALL) +* Stop rescuing any error when constantizing the resource class and allow route_prefix to be nil +* Cleaned up tests and responder structure. Whenever you pass a block to aliases and this block responds to the request, the other blocks are not parsed improving performance +* [BACKWARDS INCOMPATIBLE] By default, Inherited Resources respond only :html requests +* Added a quick way to overwrite the redirect to url in :create, :update and :destroy ## Version 0.5 -* Decoupled routes name from :instance_name and :collection_name. This way we have more flexibility. Use route_instance_name and route_collection_name to to change routes. -* Avoid calling human_name on nil when a resource class is not defined. -* Only call I18n if it's defined. +* Decoupled routes name from :instance_name and :collection_name. This way we have more flexibility. Use route_instance_name and route_collection_name to to change routes +* Avoid calling human_name on nil when a resource class is not defined +* Only call I18n if it's defined ## Version 0.4 -* Dealing with namespaced controllers out of the box. -* Added support to namespaced routes through :route_prefix. -* Added fix when resource_url is not defined. -* Added better handling for namespaced controllers. -* Added flash messages scoped by namespaced controllers. -* Deprecated {{resource}} in I18n, use {{resource_name}} instead. -* rspec bug fix is not automatically required anymore. User has to do it explicitly. -* Added a file which fix a rspec bug when render is called inside a method which receives a block. -* parent? does not take begin_of_association_chain into account anymore. -* Added options to url helpers. -* Added :optional to belongs_to associations. It allows you to deal with categories/1/products/2 and /products/2 with just one controller. -* Cleaned up tests. +* Dealing with namespaced controllers out of the box +* Added support to namespaced routes through :route_prefix +* Added fix when resource_url is not defined +* Added better handling for namespaced controllers +* Added flash messages scoped by namespaced controllers +* Deprecated {{resource}} in I18n, use {{resource_name}} instead +* rspec bug fix is not automatically required anymore. User has to do it explicitly +* Added a file which fix a rspec bug when render is called inside a method which receives a block +* parent? does not take begin_of_association_chain into account anymore +* Added options to url helpers +* Added :optional to belongs_to associations. It allows you to deal with categories/1/products/2 and /products/2 with just one controller +* Cleaned up tests ## Version 0.3 -* Minor bump after three bug fixes. -* Bug fix when showing warning of constant redefinition. -* Bug fix with ApplicationController not being unloaded properly on development. -* Bug fix when having root singleton resources. Calling `collection_url` would raise "NoMethodError \_url", not it will call root_url. -* More comments on UrlHelpers. +* Minor bump after three bug fixes +* Bug fix when showing warning of constant redefinition +* Bug fix with ApplicationController not being unloaded properly on development +* Bug fix when having root singleton resources. Calling `collection_url` would raise "NoMethodError \_url", not it will call root_url +* More comments on UrlHelpers ## Version 0.2 -* Bug fix when ApplicationController is already loaded when we load respond_to. -* Added support success/failure blocks. -* Eager loading of files to work properly in multithreaded environments. +* Bug fix when ApplicationController is already loaded when we load respond_to +* Added support success/failure blocks +* Eager loading of files to work properly in multithreaded environments ## Version 0.1 -* Added more helper_methods. -* Added Rails 2.3.0 and changed tests to work with ActionController::TestCase. -* First release. Support to I18n, singleton controllers, polymorphic controllers, belongs_to, nested_belongs_to and url helpers. +* Added more helper_methods +* Added Rails 2.3.0 and changed tests to work with ActionController::TestCase +* First release. Support to I18n, singleton controllers, polymorphic controllers, belongs_to, nested_belongs_to and url helpers [#873]: https://github.com/activeadmin/inherited_resources/pull/873 [#918]: https://github.com/activeadmin/inherited_resources/pull/918 [#921]: https://github.com/activeadmin/inherited_resources/pull/921 [#933]: https://github.com/activeadmin/inherited_resources/pull/933 [#939]: https://github.com/activeadmin/inherited_resources/pull/939 +[#942]: https://github.com/activeadmin/inherited_resources/pull/942 diff --git a/Gemfile.lock b/Gemfile.lock index 8daf429f..52e7cb13 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -2,9 +2,9 @@ PATH remote: . specs: inherited_resources (2.0.1) - actionpack (>= 6.0) + actionpack (>= 7.0) has_scope (>= 0.6) - railties (>= 6.0) + railties (>= 7.0) responders (>= 2) GEM diff --git a/gemfiles/rails_61/Gemfile b/gemfiles/rails_61/Gemfile deleted file mode 100644 index d4a2d5f3..00000000 --- a/gemfiles/rails_61/Gemfile +++ /dev/null @@ -1,19 +0,0 @@ -# frozen_string_literal: true -source 'https://rubygems.org' - -gemspec path: '../..' - -group :development do - gem 'rails', '~> 6.1.0' - - gem 'mocha' - gem 'minitest' - gem 'minitest-reporters' - gem 'rails-controller-testing' - gem 'simplecov', require: false - gem 'simplecov-cobertura' - gem 'warning' - - # FIXME: relax this dependency when Ruby 3.1 support will be dropped - gem "zeitwerk", "~> 2.6.18" -end diff --git a/gemfiles/rails_61/Gemfile.lock b/gemfiles/rails_61/Gemfile.lock deleted file mode 100644 index 7c31b055..00000000 --- a/gemfiles/rails_61/Gemfile.lock +++ /dev/null @@ -1,216 +0,0 @@ -PATH - remote: ../.. - specs: - inherited_resources (2.0.1) - actionpack (>= 6.0) - has_scope (>= 0.6) - railties (>= 6.0) - responders (>= 2) - -GEM - remote: https://rubygems.org/ - specs: - actioncable (6.1.7.10) - actionpack (= 6.1.7.10) - activesupport (= 6.1.7.10) - nio4r (~> 2.0) - websocket-driver (>= 0.6.1) - actionmailbox (6.1.7.10) - actionpack (= 6.1.7.10) - activejob (= 6.1.7.10) - activerecord (= 6.1.7.10) - activestorage (= 6.1.7.10) - activesupport (= 6.1.7.10) - mail (>= 2.7.1) - actionmailer (6.1.7.10) - actionpack (= 6.1.7.10) - actionview (= 6.1.7.10) - activejob (= 6.1.7.10) - activesupport (= 6.1.7.10) - mail (~> 2.5, >= 2.5.4) - rails-dom-testing (~> 2.0) - actionpack (6.1.7.10) - actionview (= 6.1.7.10) - activesupport (= 6.1.7.10) - rack (~> 2.0, >= 2.0.9) - rack-test (>= 0.6.3) - rails-dom-testing (~> 2.0) - rails-html-sanitizer (~> 1.0, >= 1.2.0) - actiontext (6.1.7.10) - actionpack (= 6.1.7.10) - activerecord (= 6.1.7.10) - activestorage (= 6.1.7.10) - activesupport (= 6.1.7.10) - nokogiri (>= 1.8.5) - actionview (6.1.7.10) - activesupport (= 6.1.7.10) - builder (~> 3.1) - erubi (~> 1.4) - rails-dom-testing (~> 2.0) - rails-html-sanitizer (~> 1.1, >= 1.2.0) - activejob (6.1.7.10) - activesupport (= 6.1.7.10) - globalid (>= 0.3.6) - activemodel (6.1.7.10) - activesupport (= 6.1.7.10) - activerecord (6.1.7.10) - activemodel (= 6.1.7.10) - activesupport (= 6.1.7.10) - activestorage (6.1.7.10) - actionpack (= 6.1.7.10) - activejob (= 6.1.7.10) - activerecord (= 6.1.7.10) - activesupport (= 6.1.7.10) - marcel (~> 1.0) - mini_mime (>= 1.1.0) - activesupport (6.1.7.10) - concurrent-ruby (~> 1.0, >= 1.0.2) - i18n (>= 1.6, < 2) - minitest (>= 5.1) - tzinfo (~> 2.0) - zeitwerk (~> 2.3) - ansi (1.5.0) - builder (3.3.0) - concurrent-ruby (1.3.4) - crass (1.0.6) - date (3.4.0) - docile (1.4.1) - erubi (1.13.0) - globalid (1.2.1) - activesupport (>= 6.1) - has_scope (0.8.2) - actionpack (>= 5.2) - activesupport (>= 5.2) - i18n (1.14.6) - concurrent-ruby (~> 1.0) - loofah (2.23.1) - crass (~> 1.0.2) - nokogiri (>= 1.12.0) - mail (2.8.1) - mini_mime (>= 0.1.1) - net-imap - net-pop - net-smtp - marcel (1.0.4) - method_source (1.1.0) - mini_mime (1.1.5) - mini_portile2 (2.8.7) - minitest (5.25.1) - minitest-reporters (1.7.1) - ansi - builder - minitest (>= 5.0) - ruby-progressbar - mocha (2.5.0) - ruby2_keywords (>= 0.0.5) - net-imap (0.5.1) - date - net-protocol - net-pop (0.1.2) - net-protocol - net-protocol (0.2.2) - timeout - net-smtp (0.5.0) - net-protocol - nio4r (2.7.4) - nokogiri (1.16.7) - mini_portile2 (~> 2.8.2) - racc (~> 1.4) - nokogiri (1.16.7-aarch64-linux) - racc (~> 1.4) - nokogiri (1.16.7-arm64-darwin) - racc (~> 1.4) - nokogiri (1.16.7-x86_64-darwin) - racc (~> 1.4) - nokogiri (1.16.7-x86_64-linux) - racc (~> 1.4) - racc (1.8.1) - rack (2.2.10) - rack-test (2.1.0) - rack (>= 1.3) - rails (6.1.7.10) - actioncable (= 6.1.7.10) - actionmailbox (= 6.1.7.10) - actionmailer (= 6.1.7.10) - actionpack (= 6.1.7.10) - actiontext (= 6.1.7.10) - actionview (= 6.1.7.10) - activejob (= 6.1.7.10) - activemodel (= 6.1.7.10) - activerecord (= 6.1.7.10) - activestorage (= 6.1.7.10) - activesupport (= 6.1.7.10) - bundler (>= 1.15.0) - railties (= 6.1.7.10) - sprockets-rails (>= 2.0.0) - rails-controller-testing (1.0.5) - actionpack (>= 5.0.1.rc1) - actionview (>= 5.0.1.rc1) - activesupport (>= 5.0.1.rc1) - rails-dom-testing (2.2.0) - activesupport (>= 5.0.0) - minitest - nokogiri (>= 1.6) - rails-html-sanitizer (1.6.0) - loofah (~> 2.21) - nokogiri (~> 1.14) - railties (6.1.7.10) - actionpack (= 6.1.7.10) - activesupport (= 6.1.7.10) - method_source - rake (>= 12.2) - thor (~> 1.0) - rake (13.2.1) - responders (3.1.1) - actionpack (>= 5.2) - railties (>= 5.2) - rexml (3.3.9) - ruby-progressbar (1.13.0) - ruby2_keywords (0.0.5) - simplecov (0.22.0) - docile (~> 1.1) - simplecov-html (~> 0.11) - simplecov_json_formatter (~> 0.1) - simplecov-cobertura (2.1.0) - rexml - simplecov (~> 0.19) - simplecov-html (0.13.1) - simplecov_json_formatter (0.1.4) - sprockets (4.2.1) - concurrent-ruby (~> 1.0) - rack (>= 2.2.4, < 4) - sprockets-rails (3.5.2) - actionpack (>= 6.1) - activesupport (>= 6.1) - sprockets (>= 3.0.0) - thor (1.3.2) - timeout (0.4.2) - tzinfo (2.0.6) - concurrent-ruby (~> 1.0) - warning (1.4.0) - websocket-driver (0.7.6) - websocket-extensions (>= 0.1.0) - websocket-extensions (0.1.5) - zeitwerk (2.6.18) - -PLATFORMS - aarch64-linux - arm64-darwin - ruby - x86_64-darwin - x86_64-linux - -DEPENDENCIES - inherited_resources! - minitest - minitest-reporters - mocha - rails (~> 6.1.0) - rails-controller-testing - simplecov - simplecov-cobertura - warning - zeitwerk (~> 2.6.18) - -BUNDLED WITH - 2.5.23 diff --git a/gemfiles/rails_70/Gemfile.lock b/gemfiles/rails_70/Gemfile.lock index 6ff991ab..539544bf 100644 --- a/gemfiles/rails_70/Gemfile.lock +++ b/gemfiles/rails_70/Gemfile.lock @@ -2,9 +2,9 @@ PATH remote: ../.. specs: inherited_resources (2.0.1) - actionpack (>= 6.0) + actionpack (>= 7.0) has_scope (>= 0.6) - railties (>= 6.0) + railties (>= 7.0) responders (>= 2) GEM diff --git a/gemfiles/rails_71/Gemfile.lock b/gemfiles/rails_71/Gemfile.lock index c954b35d..4b9b69ad 100644 --- a/gemfiles/rails_71/Gemfile.lock +++ b/gemfiles/rails_71/Gemfile.lock @@ -2,9 +2,9 @@ PATH remote: ../.. specs: inherited_resources (2.0.1) - actionpack (>= 6.0) + actionpack (>= 7.0) has_scope (>= 0.6) - railties (>= 6.0) + railties (>= 7.0) responders (>= 2) GEM diff --git a/gemfiles/rails_72/Gemfile.lock b/gemfiles/rails_72/Gemfile.lock index dd094a1c..3b5bdfb8 100644 --- a/gemfiles/rails_72/Gemfile.lock +++ b/gemfiles/rails_72/Gemfile.lock @@ -2,9 +2,9 @@ PATH remote: ../.. specs: inherited_resources (2.0.1) - actionpack (>= 6.0) + actionpack (>= 7.0) has_scope (>= 0.6) - railties (>= 6.0) + railties (>= 7.0) responders (>= 2) GEM diff --git a/inherited_resources.gemspec b/inherited_resources.gemspec index 99de676f..05ba0862 100644 --- a/inherited_resources.gemspec +++ b/inherited_resources.gemspec @@ -25,7 +25,7 @@ Gem::Specification.new do |s| s.required_ruby_version = '>= 3.1' s.add_dependency("responders", ">= 2") - s.add_dependency("actionpack", ">= 6.0") - s.add_dependency("railties", ">= 6.0") + s.add_dependency("actionpack", ">= 7.0") + s.add_dependency("railties", ">= 7.0") s.add_dependency("has_scope", ">= 0.6") end diff --git a/test/changelog_test.rb b/test/changelog_test.rb index 7c312897..eac93648 100644 --- a/test/changelog_test.rb +++ b/test/changelog_test.rb @@ -20,7 +20,7 @@ def test_entry_does_end_with_a_punctuation entries = lines.grep(/^\*/) entries.each do |entry| - assert_match(/(\.|\:)$/, entry) + assert_no_match(/(\.|\:)$/, entry) end end end