-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[all OSs] Android NDK 22 will be replaced in favor of 24, version 23 will be set as the default one on June, 6 #5595
Comments
Will be deployed next week. |
At least my builds are failing since the NDK 23 being default was deployed already? |
@Bercon no, it was not. The new image rollout will start today |
After further debugging, it appears my issue is most likely ndk 23 updating from 23.1 to 23.2 which didn't work out of the box with https://github.com/moritz-wundke/Boost-for-Android we are using. |
See actions/runner-images#5595 Pull Request resolved: #79024 Approved by: https://github.com/janeyx99
Summary: See actions/runner-images#5595 Pull Request resolved: #79024 Approved by: https://github.com/janeyx99 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/0be9df4e852c0216a1de749551f16affddb63335 Reviewed By: osalpekar Differential Revision: D36993242 Pulled By: kit1980 fbshipit-source-id: c2e76fee4eaf0b1474cb7221721cbb798c319001
To account for recent changes to defaults: actions/runner-images#5595 Signed-off-by: JP Simard <[email protected]>
To account for recent changes to defaults: actions/runner-images#5595 Signed-off-by: JP Simard <[email protected]>
…o reuse in `--` subcommand Winit is currently being hit by `-lgcc not found` linker errors because GH Actions' [virtual-environments recently migrated to Android NDK r23], and it turns out it's using the niche `--` subcommand to invoke regular `cargo` commands under an NDK environment. The workaround using `RUSTFLAGS` is only patched into the `build()` command; by moving it into our `cargo_ndk()` environment preparation function this workaround is universally available and usable. Note that this is a breaking change, we're changing the API signature of `ndk-build`. [virtual-environments recently migrated to Android NDK r23]: actions/runner-images#5595
…o reuse in `--` subcommand Winit is currently being hit by `-lgcc not found` linker errors because GH Actions' [virtual-environments recently migrated to Android NDK r23], and it turns out it's using the niche `--` subcommand to invoke regular `cargo` commands under an NDK environment. The workaround using `RUSTFLAGS` is only patched into the `build()` command; by moving it into our `cargo_ndk()` environment preparation function this workaround is universally available and usable. Note that this is a breaking change, we're changing the API signature of `ndk-build`. [virtual-environments recently migrated to Android NDK r23]: actions/runner-images#5595
…o reuse in `--` subcommand (#286) Winit is currently being hit by `-lgcc not found` linker errors because GH Actions' [virtual-environments recently migrated to Android NDK r23], and it turns out it's using the niche `--` subcommand to invoke regular `cargo` commands under an NDK environment. The workaround using `RUSTFLAGS` is only patched into the `build()` command; by moving it into our `cargo_ndk()` environment preparation function this workaround is universally available and usable. Note that this is a breaking change, we're changing the API signature of `ndk-build`. [virtual-environments recently migrated to Android NDK r23]: actions/runner-images#5595
Summary: See actions/runner-images#5595 Pull Request resolved: pytorch#79024 Approved by: https://github.com/janeyx99 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/0be9df4e852c0216a1de749551f16affddb63335 Reviewed By: osalpekar Differential Revision: D36993242 Pulled By: kit1980 fbshipit-source-id: c2e76fee4eaf0b1474cb7221721cbb798c319001
Summary: See actions/runner-images#5595 Pull Request resolved: #79024 Approved by: https://github.com/janeyx99 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/0be9df4e852c0216a1de749551f16affddb63335 Reviewed By: osalpekar Differential Revision: D36993242 Pulled By: kit1980 fbshipit-source-id: c2e76fee4eaf0b1474cb7221721cbb798c319001 Co-authored-by: Sergii Dymchenko (Meta Employee) <[email protected]>
GitHub updated the versions of NDK installed on the Actions runners breaking the ARM tests. Restore the NDKv21 using the GitHub suggested mitigation, see: actions/runner-images#5595 closes official-stockfish#4077 No functional change
* This will fix the CI errors on GitHub. * actions/runner-images#5595 PiperOrigin-RevId: 455520163
Thanks for this work! But how exactly can I make sure my build uses ndk r24 instead of the default 23 on the Ubuntu 22.04 image? See https://github.com/openMSX/openMSX/actions/workflows/build_snapshots.yml |
@MBilderbeek you can try the following snippet to replace ndk-bundle with NDK r24 ANDROID_ROOT=/usr/local/lib/android
ANDROID_SDK_ROOT=${ANDROID_ROOT}/sdk
ANDROID_NDK_ROOT=${ANDROID_SDK_ROOT}/ndk-bundle
ln -sfn $ANDROID_SDK_ROOT/ndk/24.0.8215888 $ANDROID_NDK_ROOT |
@miketimofeev Thanks, got it working by just adding this step: |
To account for recent changes to defaults: actions/runner-images#5595 Signed-off-by: JP Simard <[email protected]> Signed-off-by: Rafal Augustyniak <[email protected]>
related to dotnet/android#6808 (comment) |
To account for recent changes to defaults: actions/runner-images#5595 Signed-off-by: JP Simard <[email protected]>
Breaking changes
There are two changes:
Target date
The propagation is starting on June, 6 and will take 3-4 days
The motivation for the changes
According to our Software and image guidelines we support 1 latest non-LTS and 2 latest LTS versions of NDK. Currently, our image contains NDK r22 whereas the latest non-LTS is 24. LTS version of NDK 21 is not supported so we would like to set version 23 as the new default.
Possible impact
Virtual environments affected
Mitigation ways
The text was updated successfully, but these errors were encountered: