From 83fc7d3af21c544886ac1dd38f98dc211ceda616 Mon Sep 17 00:00:00 2001 From: Iris Hoffmeyer Date: Tue, 11 Aug 2020 13:31:58 -0400 Subject: [PATCH 1/2] Switch extractZipNix to use the -n prompt Without expressing a preference on whether to overwrite a file or not, unzip, by default, will prompt for user input on what it should do. Causing any CI actions that use this function to timeout, which is undesirable. This causes issues in actions upstream such as https://github.com/actions-rs/install/issues/6 --- packages/tool-cache/src/tool-cache.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/tool-cache/src/tool-cache.ts b/packages/tool-cache/src/tool-cache.ts index 3e9ecab409..04f8423813 100644 --- a/packages/tool-cache/src/tool-cache.ts +++ b/packages/tool-cache/src/tool-cache.ts @@ -360,7 +360,7 @@ async function extractZipWin(file: string, dest: string): Promise { async function extractZipNix(file: string, dest: string): Promise { const unzipPath = await io.which('unzip', true) - const args = [file] + const args = [file, '-n'] if (!core.isDebug()) { args.unshift('-q') } From fc42ad018e1116231e901f8da3055d0983731e44 Mon Sep 17 00:00:00 2001 From: Iris Faey Hoffmeyer Date: Tue, 11 Aug 2020 14:14:07 -0400 Subject: [PATCH 2/2] Put options in the correct order This fixes the unzip tests --- packages/tool-cache/src/tool-cache.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/tool-cache/src/tool-cache.ts b/packages/tool-cache/src/tool-cache.ts index 04f8423813..73441c7e40 100644 --- a/packages/tool-cache/src/tool-cache.ts +++ b/packages/tool-cache/src/tool-cache.ts @@ -360,7 +360,7 @@ async function extractZipWin(file: string, dest: string): Promise { async function extractZipNix(file: string, dest: string): Promise { const unzipPath = await io.which('unzip', true) - const args = [file, '-n'] + const args = ['-n', file] if (!core.isDebug()) { args.unshift('-q') }