Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem matchers: Code is not actually using EcmaScript-style regexs as documented #482

Closed
lumaxis opened this issue May 27, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@lumaxis
Copy link

lumaxis commented May 27, 2020

I'm not 100% sure that this is really the case since my understanding of Dotnet and C# is pretty limited but the current documentation seems to suggest that the problem matchers use EcmaScript-style regex syntax but I don't see the necessary options being passed here: https://github.com/actions/runner/blob/6c70d53eead402ba5d53676d6ed649a04e219c9b/src/Runner.Worker/IssueMatcher.cs#L68
The default seems to be to use canonical regex synatx: https://docs.microsoft.com/en-us/dotnet/standard/base-types/regular-expression-options#default-options

@lumaxis lumaxis added the bug Something isn't working label May 27, 2020
@thboop
Copy link
Collaborator

thboop commented Jun 25, 2020

Hey @lumaxis , they are passed in here: https://github.com/actions/runner/blob/6c70d53eead402ba5d53676d6ed649a04e219c9b/src/Runner.Worker/IssueMatcher.cs#L408

I'm going to close this issue out, as it appears to be working as expected, but if you are still seeing issues with it not using EMCAScript let me know and I'll reopen!

@thboop thboop closed this as completed Jun 25, 2020
@lumaxis
Copy link
Author

lumaxis commented Jun 25, 2020

Fantastic, thanks for digging that up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants