Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem matchers which match an invalid file cause annotations to come up as being in the file .github #473

Open
peternewman opened this issue May 26, 2020 · 3 comments
Labels
bug Something isn't working external

Comments

@peternewman
Copy link

Describe the bug
If a problem matcher doesn't match a valid file (e.g. the regex captures "test.txt ", with a space at the end, the annotation comes up as being in the file .github rather than the matched file.

To Reproduce
Create a problem matcher which matches at least an invalid filename, or possibly a file not in the repo.

Expected behavior
Either not annotating .github, or annotating the match for a filename that doesn't exist, or perhaps clearest some sort of error somewhere (perhaps in the action log), that the matched filename doesn't exist.

@peternewman peternewman added the bug Something isn't working label May 26, 2020
@bilderbuchi
Copy link

bilderbuchi commented Oct 24, 2020

"annotating the match for a filename that doesn't exist" sounds most useful, and maybe if possible indicate that the file was not found in the repo. Although, tbh, .github is also not a file, but a directory..

@peternewman
Copy link
Author

Although, tbh, .github is also not a file..

I think the issue was if it shows up on .github you can't tell which file it was trying to tag and therefore work out what was going on.

@bilderbuchi
Copy link

Yes, exactly. That was more a quip that .github is a directory, not a file. Well, it's late :-P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external
Projects
None yet
Development

No branches or pull requests

3 participants