Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set deployment state to in_progress #443

Closed
sergeysova opened this issue May 3, 2020 · 1 comment
Closed

Cannot set deployment state to in_progress #443

sergeysova opened this issue May 3, 2020 · 1 comment
Labels
bug Something isn't working github

Comments

@sergeysova
Copy link

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:
1.

    client.repos.createDeploymentStatus({
      ...context.repo,
      deployment_id: deploymentId,
      state: "in_progress",
    });
  1. HttpError: Validation Failed
  2. Because: https://developer.github.com/v3/repos/deployments/#parameters-2

To use the inactive state, you must provide the application/vnd.github.ant-man-preview+json custom media type. To use the in_progress and queued states, you must provide the application/vnd.github.flash-preview+json custom media type.

Expected behavior
createDeploymentStatus automatically sets media type if state is requires it.

Ref: https://github.com/authmenow/releases/runs/630056476?check_suite_focus=true (Deployment success), chrnorm/deployment-status#8

@sergeysova sergeysova added the bug Something isn't working label May 3, 2020
@thboop thboop added the github label Jun 25, 2020
@thboop
Copy link
Collaborator

thboop commented May 20, 2021

This should be fixed in @actions/github 5.0.0 please let me know if you are still seeing issue and we can reopen the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github
Projects
None yet
Development

No branches or pull requests

2 participants