Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to limit notifications per run #943

Closed
rcomer opened this issue Feb 26, 2023 · 4 comments
Closed

Option to limit notifications per run #943

rcomer opened this issue Feb 26, 2023 · 4 comments
Labels
feature request New feature or request to improve the current logic

Comments

@rcomer
Copy link

rcomer commented Feb 26, 2023

Description:
Have a new option so that the action stops after it has made N actions (comment or close) that trigger a notification. N should be configurable by the user.

Justification:
Over in Matplotlib we have a lot of old issues to sift through, but we would also like to keep the number of notifications generated each day by the action fairly minimal. Currently we have set the operations-per-run to a modest 30 to achieve the latter, but we know that, due to #792, we will need to keep increasing this to make more progress through the issue backlog. With the proposed new option, we could set the operations-per-run to something high and notifications per run to something low, and thereby make slow but steady progress through our backlog.

Are you willing to submit a PR?
Potentially, but I have never done anything with actions or typescript, so I would need a lot of guidance.

@rcomer rcomer added feature request New feature or request to improve the current logic needs triage labels Feb 26, 2023
@panticmilos
Copy link
Contributor

hi @rcomer, thank you for the report. We will take a look at it :)

@rcomer
Copy link
Author

rcomer commented Apr 4, 2023

The action has now started closing issues in Matplotlib. It seems to be finding a pretty good equilibrium, in that closing issues frees up some operations for the next run (still a lot of old issues need labelling!) So I do not think this feature would make so much difference for us now.

I’ll leave this open in case you think it would be useful for other projects, but also happy if you prefer to close. Sorry for the noise.

@dsame
Copy link
Contributor

dsame commented Aug 4, 2023

Hello @rcomer , #792 already has a fix in the main branch, so will the problem be solved if the operations-per-run kept low?

@rcomer
Copy link
Author

rcomer commented Aug 4, 2023

Hi @dsame, thanks for the ping. I had not noticed that #792 was closed. So if I've understood the change at #1033, the action will focus on finding new things to label as stale before it checks the ones already labelled. I certainly think that makes this issue redundant.

@rcomer rcomer closed this as not planned Won't fix, can't repro, duplicate, stale Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

3 participants