Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statistics after run #262

Closed
tobiasdiez opened this issue Jan 4, 2021 · 12 comments · Fixed by #337
Closed

Add statistics after run #262

tobiasdiez opened this issue Jan 4, 2021 · 12 comments · Fixed by #337
Labels
enhancement New feature or request

Comments

@tobiasdiez
Copy link
Contributor

It would be nice to have a basic statistics after the action run, e.g. issues looked at, number of issues marked stale, number of issues no longer stale, number of issues closed etc.

@hross hross added the enhancement New feature or request label Jan 15, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Feb 15, 2021
@tobiasdiez
Copy link
Contributor Author

Still relevant, and has a few upvotes already.

@github-actions github-actions bot removed the Stale label Feb 16, 2021
@C0ZEN
Copy link
Contributor

C0ZEN commented Feb 21, 2021

At some point I am interested to provide a PR for this but I am prioritizing other features right now.

@C0ZEN
Copy link
Contributor

C0ZEN commented Feb 27, 2021

@tobiasdiez looking into it right now.
I was thinking that:

  • it should be a new option (default at false)
  • it should display the information at the end of the logs
  • it should display the count of processed issues and PRs (for now, not distinguish but I think it can be cool to have two section, one for the issues and one for the PRs but it's a lot of extra work)
  • it should display the count of operations
  • it should display all CRD API calls related to GitHub

@tobiasdiez
Copy link
Contributor Author

Thanks for looking into it.

it should be a new option (default at false)

Not sure if this really needs to be configurable. In case you are not interested in the output, you can simply ignore it (and the computation cost doesn't seem to be high).

it should display the count of operations
it should display all CRD API calls related to GitHub

At least for my use case, this is not really the information I'm interested in (but maybe other people are). For me, it was more important to see how many issues are newly marked stale and how many issues are no longer stale.

@tobiasdiez
Copy link
Contributor Author

Thanks a lot!

@C0ZEN
Copy link
Contributor

C0ZEN commented Mar 1, 2021

@tobiasdiez this is a first draft so feel free to open a new issue if you think that there is some missing stats or if it can be improved somehow.

@tobiasdiez
Copy link
Contributor Author

tobiasdiez commented Mar 18, 2021

Thanks for the implementation!
Currently it prints statistics such as

Statistics
Processed issues/PRs: 233
Operations performed: 28
Fetched issues: 4
Fetched issues events: 10
Fetched issues comments: 10

These are great for debugging / analyzing but I was hoping a bit more for user-focused stats such as number of issues marked stale, number of issues no longer stale and number of issues closed so that one as a maintainer gets a quick overview.

@C0ZEN
Copy link
Contributor

C0ZEN commented Mar 19, 2021

@tobiasdiez and all of those stats were added as well but only display if at least one of the event occurred

@tobiasdiez
Copy link
Contributor Author

Ah ok, thanks!
May I then suggest to always display, with 0?

@C0ZEN
Copy link
Contributor

C0ZEN commented Mar 19, 2021

@tobiasdiez Since there is a lot of stats (and also I have a PR which split the stats between PR and issues) and based on the actions, some could basically display them all if there is a lot of activities and some almost nothing I prefer to have "useful" stats instead of seeing a bunch of nothing...

@tobiasdiez
Copy link
Contributor Author

I would say knowing that no new issues were marked as stale is a useful information but I trust your judgement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants