Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limit token does not work on GHE #638

Closed
2 tasks done
mvs5465 opened this issue Mar 28, 2023 · 7 comments
Closed
2 tasks done

Rate limit token does not work on GHE #638

mvs5465 opened this issue Mar 28, 2023 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@mvs5465
Copy link

mvs5465 commented Mar 28, 2023

Description:
Using the token parameter for the Github Action, the token is not used.

Action version:
v4

Platform:

  • Ubuntu

Runner type:

  • Self-hosted

Tools version:
3.x

Repro steps:
Add a Github Action workflow like this to your Github Enterprise repository:

      - name: Install Python
        uses: actions/setup-python@v4
        with:
          token: ${{ secrets.DOTCOM_TOKEN }}
          python-version: '3.x'

Then also add #510 (comment) using the same token variable.

We can tell by the rate-limit response that the token has not been used.

Expected behavior:

Expect action to use token.

Actual behavior:

API rate limit exceeded for <ip>

We confirmed using the rate limit query that the rate limit quotas have not changed, and thus the token has not been used by the action.

@mvs5465 mvs5465 added bug Something isn't working needs triage labels Mar 28, 2023
@e-korolevskii
Copy link
Contributor

Hello @mvs5465
Thank you for your report. We'll investigate the issue and get back to you.

@chebong-aus
Copy link

Hi @e-korolevskii, are there any updates on this issue? I am facing the exact same issue in my GitHub Enterprise repository.

@dmitry-shibanov
Copy link
Contributor

Hello everyone. Could you please take a look at this issue because I think they're related.

@dmitry-shibanov dmitry-shibanov self-assigned this Jul 10, 2023
@chebong-aus
Copy link

Hi @dmitry-shibanov, looking at the link you provided, not sure if they are related because the error I get is Error: API rate limit exceeded for x. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.). This is while passing in a GitHub.com Token.

@priya-kinthali
Copy link
Contributor

Hello @mvs5465 👋,
Could you kindly verify if the issue related to the rate limit has been resolved and confirm that no other issues have emerged while using the setup-actions-demo/setup-python@main branch.

@priya-kinthali
Copy link
Contributor

Hello @mvs5465👋,
Just a gentle reminder, Could you kindly verify if the issue related to the rate limit has been resolved and confirm that no other issues have emerged while using the setup-actions-demo/setup-python@main branch.

@priya-kinthali
Copy link
Contributor

Hello @mvs5465 👋,
As part of the latest updates, the potential improvement to leverage the raw API for retrieving version-manifest has been implemented and released in v5.1.0. This new approach should mitigate the rate limit exhaustion without requiring an additional GitHub token.
Please update to the latest version and let us know if you encounter any further issues. As this update resolves the reported problem, we will close this issue.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants