Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for npm-shrinkwrap.json #302

Closed
edukisto opened this issue Jul 19, 2021 · 3 comments
Closed

Support for npm-shrinkwrap.json #302

edukisto opened this issue Jul 19, 2021 · 3 comments

Comments

@edukisto
Copy link

Is it possible to use not only package-lock.json or yarn.lock but also npm-shrinkwrap.json when caching package dependencies?
@AlenaSviridenko
Copy link
Contributor

Hi @edukisto, we have an ADR to support monorepos and projects with complex structure that will also make it possible to specify path to npm-shrinkwrap.json so it can be used as a dependencies source.
It will be implemented in the upcoming couple of months.

@edukisto
Copy link
Author

That’s great! We are looking forward to it! Thank you, @AlenaSviridenko!

This was referenced Jul 20, 2021
Closed
Merged
@dreamorosi dreamorosi mentioned this issue Jul 20, 2021
Closed
@dmitry-shibanov
Copy link
Contributor

Hello @edukisto. The pull request with adding support for monorepos and projects with complex structure was merged. You can specify npm-shrinkwrap.json with this code snippet.

- uses: actions/setup-node@v2
  with:
    node-version: '14'
    cache: 'npm'
    cache-dependency-path: npm-shrinkwrap.json

For now I'm closing the issue. If you have any concerns feel free to ping me in the thread.

@JGAntunes JGAntunes mentioned this issue Aug 31, 2021
Merged
@michaelBenin michaelBenin mentioned this issue Sep 10, 2021
Open
@strugee strugee mentioned this issue Mar 9, 2022
Merged
2 tasks
deining pushed a commit to deining/setup-node that referenced this issue Nov 9, 2023
@dependabot
chore(deps): bump @actions/core from 1.5.0 to 1.6.0 (actions#302)
39cfc84 
Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/actions/toolkit/releases)
- [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md)
- [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core)

---
updated-dependencies:
- dependency-name: "@actions/core"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AlenaSviridenko @dmitry-shibanov @edukisto