Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Java version from .tool-versions file #579

Closed
paulschreiber opened this issue Dec 28, 2023 · 3 comments
Closed

Get Java version from .tool-versions file #579

paulschreiber opened this issue Dec 28, 2023 · 3 comments
Assignees
@mahabaleshwars
Labels
feature request New feature or request to improve the current logic

Comments

@paulschreiber
Copy link

Description:
Please add support for getting the Java version from the .tool-versions file.

Justification:
This is supported by actions/setup-node, which we also use. Having a separate .java-version file (added in 3.9.0) is less efficient.
@paulschreiber paulschreiber added feature request New feature or request to improve the current logic needs triage labels Dec 28, 2023
@aparnajyothi-y
Copy link
Contributor

Hello @paulschreiber, Thanks for the feature request, we will take a look and get back to you with our decision.

@mahabaleshwars mahabaleshwars mentioned this issue Mar 5, 2024
Merged
2 tasks
@rtyley rtyley mentioned this issue Mar 28, 2024
Closed
5 tasks
@mahabaleshwars
Copy link
Contributor

Hi @paulschreiber,
We have added the functionality to extract the Java version from a .tool-versions file in actions/[email protected]. Hence we are proceeding to close this issue.
Please feel free to reach us in case of any further concerns/clarifications needed.

@paulschreiber
Copy link
Author

Thanks. Can you update the README with an example? i.e. do I use
java-version-file: '.tool-versions'

as with actions/setup-node?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahabaleshwars mahabaleshwars

Labels
feature request New feature or request to improve the current logic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@paulschreiber @IvanZosimov @aparnajyothi-y @mahabaleshwars