Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Maven options to allow maven central mirror url #486

Closed
wenqiglantz-agi opened this issue Apr 20, 2023 · 3 comments
Closed

Request Maven options to allow maven central mirror url #486

wenqiglantz-agi opened this issue Apr 20, 2023 · 3 comments
Labels
feature request New feature or request to improve the current logic

Comments

@wenqiglantz-agi
Copy link

Description:
Currently setup-java action generates the default maven settings.xml on the fly. It defaults to the maven central URL https://repo.maven.apache.org/, which unfortunately had an incident for a few hours on 4/19/2023 when that URL went down and our github actions workflows for CI stopped working. I would like to request if you could add additional option(s) in setup-java action to allow users to enter a maven central mirror URL such as https://repo1.maven.org/maven2 to work around incident like that if/when it occurs.

Justification:
In case of the default maven central URL goes offline, we need a way in the github actions CI workflows to instruct settings.xml auto generated by this action to point to a mirror URL for maven central.

Are you willing to submit a PR?

@wenqiglantz-agi wenqiglantz-agi added feature request New feature or request to improve the current logic needs triage labels Apr 20, 2023
@IvanZosimov
Copy link
Contributor

Hi, @wenqiglantz-agi 👋 Thanks for the feature request, we will take a look at it!

@IvanZosimov
Copy link
Contributor

Hi, @wenqiglantz-agi 👋 Unfortunately, we decided to reject your feature request. We believe that adding the functionality that you asked for will add unwanted complexity to the action (one more input and additional logic). Moreover, such incidents with Maven Central are pretty rare, and their consequences could be fixed manually in the steps following the installation of Java.

@IvanZosimov IvanZosimov closed this as not planned Won't fix, can't repro, duplicate, stale Sep 1, 2023
@rhuitl
Copy link

rhuitl commented May 29, 2024

We are using self-hosted runners and want to use a Maven mirror to reduce the traffic over our internet connection and speed up things. A way to merge the auto-generated settings.xml and our own file, or explicit support for adding mirrors, would have been nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

3 participants