-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a note in the readme how to export a gpg key #100
Comments
Maybe we should export it using:
Right? Can we just add something similar in the readme? |
this helped, thanks |
This actually fixed a 2 day nerve wracking spiral of coding |
Wow, this helped in a massive way! There's so many different ways to do all this gpg business, with plenty of guides out there having outdated info, e.g. https://terribletester.com/publishing-to-maven-central-and-github-packages-with-github-actions and https://zambrovski.medium.com/foss-ci-cd-with-github-actions-c65c37236c19. The big issue is that you go to the official guide (https://docs.github.com/en/free-pro-team@latest/actions/guides/publishing-java-packages-with-maven) and has no info whatsoever on the gpg requirements, so you end up trying to lookup things and you find outdated info. To be more precise, one of those outdated external guides said to do:
I had my GPG key as a result of doing that, but then the GH action failed with no info whatsoever:
Why did it fail? No idea... and then I somehow came across this issue and exporting it with the command above meant it then at least went pass that stage... But we're not out of the woods, then you get:
This has been noted several times, like in #83, but yet again, no trace of this in the official guide... :( |
Hello, everyone. I'm closing this issue, because documentation was updated in terms of this pull request. If you have any concerns feel free to reopen the issue. |
The updated documentation reads
Is this correct? Based on the provided command I would have expected it to read
|
This action can automatically configure gpg key if we set:
But it is not clear for me what
MAVEN_GPG_PRIVATE_KEY
secret should contain. I have generated a gpg key in my local machine but how should I export it to be valid?Maybe we can add a note in the readme?
thanks
The text was updated successfully, but these errors were encountered: