Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use check-latest: true but it doesn't work #287

Closed
2 tasks done
li-jin-gou opened this issue Nov 7, 2022 · 4 comments
Closed
2 tasks done

use check-latest: true but it doesn't work #287

li-jin-gou opened this issue Nov 7, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@li-jin-gou
Copy link

li-jin-gou commented Nov 7, 2022

Description:
I want to set check-latest to get go version 1.19.3, but it still gets version 1.19.2
this is pr: gofiber/fiber#2197

Action version:

V3

Platform:

  • Ubuntu

Runner type:

  • Hosted

Repro steps:

on: [push, pull_request_target]
name: Vulnerability Check
jobs:
  Security:
    runs-on: ubuntu-latest
    steps:
    - name: Install Go
      uses: actions/setup-go@v3
      with:
        go-version: 1.19
        check-latest: true
    - name: Fetch Repository
      uses: actions/checkout@v3
    - name: Install Govulncheck
      run: |
          export GO111MODULE=on
          export PATH=${PATH}:`go env GOPATH`/bin
          go install golang.org/x/vuln/cmd/govulncheck@latest
    - name: Run Govulncheck
      run: "`go env GOPATH`/bin/govulncheck ./..."

Expected behavior:

Go version equal to 1.19.3

Actual behavior:

Go version equal to 1.19.2

@dmitry-shibanov
Copy link
Contributor

Hello @li-jin-gou. I've tried to reproduce the issue but it works as expected. In your case it looks like the changes were not applied.
image

@li-jin-gou
Copy link
Author

Hello @li-jin-gou. I've tried to reproduce the issue but it works as expected. In your case it looks like the changes were not applied. image

Yes, It works fine in my own fork repository, but it doesn't work after committing to fiber.

@li-jin-gou
Copy link
Author

li-jin-gou commented Nov 8, 2022

Hello @dmitry-shibanov any progress?❤️

@li-jin-gou
Copy link
Author

already solve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants