Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Documentation To Reference Latest Version #139

Closed
aolszowka opened this issue Oct 23, 2020 · 4 comments
Closed

Update Documentation To Reference Latest Version #139

aolszowka opened this issue Oct 23, 2020 · 4 comments

Comments

@aolszowka
Copy link

Description

The documentation in README.md should be updated to reflect the latest/greatest version of the Action.

Details

I was having issues using the provided example to push a package to GPR, however after reading #101 (comment) it appears it was because I was using an older release (@v1 as opposed to @v1.7.2)

Out of the box (and not knowing any better) I simply copy and pasted the example to get started.

This would improve on boarding for new users.

@GGG-KILLER
Copy link
Contributor

The v1 tag is pointing to the same version as the v1.7.2 tag:
image

@aolszowka
Copy link
Author

Interesting, didn't work for me until I explicitly changed the version, if that is what is expected more power to ya.

@vsafonkin
Copy link

Hello @aolszowka , do you still have any issues with it?

@aolszowka
Copy link
Author

@vsafonkin In my usages I needed to explicitly declare the tag.

However the only reason I was using this was to push to the GitHub Package Repo (GPR) however this even became flaky itself, so I have switched to explicitly declaring the repo and not relying on this setup action like so:

      # Publish the Package, but only if on Master
      - name: Publish the package to GPR (Release ONLY)
        if: ${{ github.ref == 'refs/heads/master' }}
        run: dotnet nuget push 'nupkg/*.nupkg' --source https://nuget.pkg.github.com/${{github.repository_owner}}/index.json --api-key ${GITHUB_TOKEN} --skip-duplicate
        env:
          GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}

As this has not received any traction I am just going to close this as "wont-fix".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants