Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to run a workflow by id on ephemeral runners #2106

Closed
fkorotkov opened this issue Sep 6, 2022 · 3 comments
Closed

Allow to run a workflow by id on ephemeral runners #2106

fkorotkov opened this issue Sep 6, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@fkorotkov
Copy link

Describe the enhancement

Right now the recommended way for auto-scaling runners is to listen for workflow_job event and create runners on-demand.

If there are several workflow_job events are coming in parallel and we create multiple runners that execute ./run.sh script then we don't have guarantee which workflow will be executed on which runner. It will be nice if we could pre-assign workflow to a particular ephemeral runner so when there is a completed workflow_job event it's easier to clean it up.

./run.sh --workflow-id 123456789
@kmaehashi
Copy link

👍
This will also allow deploying self-hosted runners securely, especially in public repositories.

In our OSS project, we want to implement a pull-request CI workflow that runs only when maintainers approve. A workflow_job payload contains sender so we can check whether the workflow run was triggered by maintainers or not, however, after the runner is launched, attackers may "steal" the launched runner, as the runner is not bound to the specific run.

@nwf
Copy link

nwf commented Sep 20, 2022

This is a duplicate of #620, I think, but it would be very nice to have.

@nikola-jokic
Copy link
Contributor

Hey, I will close this issue as a duplicate. Thank you, @nwf, for answering! For everyone following, please provide 👍 on the issue #620 so we can see the interest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants