Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Enable FS-iSCSITarget-Server #708

Closed
2 of 5 tasks
pradyunsg opened this issue Apr 11, 2020 · 6 comments
Closed
2 of 5 tasks

Add/Enable FS-iSCSITarget-Server #708

pradyunsg opened this issue Apr 11, 2020 · 6 comments
Assignees
Labels
Area: Scripting and command line awaiting-deployment Code complete; awaiting deployment and/or deployment in progress enhancement New feature or request OS: Windows

Comments

@pradyunsg
Copy link

pradyunsg commented Apr 11, 2020

Tool information

  • Tool name: FS-iSCSITarget-Server (feature of Windows)
  • Add or update? Add (more like, enable out-of-the-box)
  • Desired version: The one that comes as part of respective Windows version
  • Approximate size:
  • If this is an add request:
    • Brief description of tool: Allows for putting a directory in a RAMdisk
    • URL for tool's homepage: It's an optional feature of Windows

Area for Triage: Packages / Scripting and command line (I guess?)

Question, Bug, or Feature?: Feature

Virtual environments affected

  • macOS 10.15
  • Ubuntu 16.04 LTS
  • Ubuntu 18.04 LTS
  • Windows Server 2016 R2
  • Windows Server 2019

Can this tool be installed during the build?
Yes, it can be installed during the build; adds 30 seconds to every build.

Are you willing to submit a PR?
I don't know enough about Windows, to be able to file a PR... but I am willing to do so if I could get pointers, about what would need to be done.

See https://github.com/microsoft/azure-pipelines-image-generation/issues/1353 for original upstream request that @vtbassmatt filed based on our feedback + request in pypa/pip#7263.

@maxim-lobanov
Copy link
Contributor

Hello @pradyunsg ,
Did you consider enabling this feature in runtime? As I know, enabling of this feature doesn't require reboot so it can be enabled in runtime using the following command (you should add PowerShell step at the begin of your pipeline with the following code):

Install-WindowsFeature -Name FS-iSCSITarget-Server -IncludeAllSubFeature -IncludeManagementTools

Could you please try and confirm that it works for you?

@pradyunsg
Copy link
Author

pradyunsg commented Apr 11, 2020

@maxim-lobanov o/

We do that already -- it was added to our pipeline in pypa/pip#7263. This issue is a request for it to be enabled by default. There's more context on why we would like this is in https://github.com/microsoft/azure-pipelines-image-generation/issues/1353#issuecomment-578533816.

This issue is a follow up on pypa/pip#7263 (comment), which resulted in a filing of microsoft/azure-pipelines-image-generation#1353 which was closed when the repository moved.

@maxim-lobanov
Copy link
Contributor

@pradyunsg , thank you for context!
I believe that makes sense to enable it by default

@pradyunsg
Copy link
Author

@maxim-lobanov Thank you! What would be the next step to enable this by default?

@maxim-lobanov
Copy link
Contributor

сс @alepauly to take a look and approve for work when you have a chance

@al-cheb al-cheb self-assigned this Apr 29, 2020
@al-cheb al-cheb mentioned this issue Apr 29, 2020
4 tasks
@al-cheb al-cheb added the awaiting-deployment Code complete; awaiting deployment and/or deployment in progress label May 6, 2020
@al-cheb
Copy link
Contributor

al-cheb commented May 13, 2020

Hello, @pradyunsg
The FS-iSCSITarget-Server feature is now pre-installed on Windows images. Feel free to open the thread if you have any concerns.

fs - Copy

@al-cheb al-cheb closed this as completed May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Scripting and command line awaiting-deployment Code complete; awaiting deployment and/or deployment in progress enhancement New feature or request OS: Windows
Projects
None yet
Development

No branches or pull requests

5 participants