Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker to mac images #4399

Closed
3 of 9 tasks
scbedd opened this issue Nov 2, 2021 · 2 comments
Closed
3 of 9 tasks

Add docker to mac images #4399

scbedd opened this issue Nov 2, 2021 · 2 comments
Labels
Area: Containers duplicate This issue or pull request already exists feature request OS: macOS

Comments

@scbedd
Copy link

scbedd commented Nov 2, 2021

Tool name

docker

Tool license

Uncertain what our licensing issue is for Windows/Linux version. Would be the same on Mac.

Add or update?

  • Add
  • Update

Desired version

latest

Approximate size

No response

Brief description of tool

I don't think I need to tell you folks what docker is. I'd be willing to put money on the fact that you know more about it than I do :)

That being said, right now, it comes pre-installed on the Windows and Linux images. What can I do to get a similar experience on mac? I'm willing to listen to suggestions here 👍

URL for tool's homepage

https://www.docker.com/

Provide a basic test case to validate the tool's functionality.

docker container create -p 5001:5001 -p 5000:5000 --name ambitious_azsdk_test_proxy azsdkengsys.azurecr.io/engsys/testproxy-lin:1108695
docker container start ambitious_azsdk_test_proxy

Virtual environments affected

  • Ubuntu 18.04
  • Ubuntu 20.04
  • macOS 10.15
  • macOS 11
  • Windows Server 2016
  • Windows Server 2019
  • Windows Server 2022

Can this tool be installed during the build?

To my knowledge, no. Whenever I have attempted installation of `docker` via any CLI, I need to restart the agent to see an affect.

This is why I want to say it's seemingly an agent level change.

Tool installation time in runtime

~5 minutes, mostly download time.

Are you willing to submit a PR?

Totally willing to help. Will just need some pointers on testing a macos specific change :)

@scbedd scbedd changed the title Update/Add docker to mac images Add docker to mac images Nov 2, 2021
@dibir-magomedsaygitov
Copy link
Contributor

Hello @scbedd. Thank you for your request. We will take a look.

@miketimofeev miketimofeev added duplicate This issue or pull request already exists and removed needs eyes labels Nov 2, 2021
@miketimofeev
Copy link
Contributor

Hi @scbedd!
Unfortunately, we can not add docker due to license restrictions. Please take a look at this issue and the advice given there #2150
I'm going to close this issue. Please feel free to contact us if you have any concerns.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Containers duplicate This issue or pull request already exists feature request OS: macOS
Projects
None yet
Development

No branches or pull requests

3 participants