fix ref for pr closed event when a pr is merged #141

ericsciple · 2020-01-21T06:46:51Z

fixes #136

ericsciple · 2020-01-21T06:51:01Z

dist/index.js

@@ -12757,6 +12757,11 @@ function getInputs() {
        if (isWorkflowRepository) {
            result.ref = github.context.ref;
            result.commit = github.context.sha;
+            // Some events have an unqualifed ref. For example when a PR is merged (pull_request closed event),


@andymckay is this a bug on the server? Seems like github.ref would always be qualified (e.g. refs/heads/master not master). For most events it's qualified. PR closed_event (when a PR is merged) is the only case I'm aware it's not.

I'm still planning to proceed with this fix here for resiliency, but just FYI since this seems like a bug on the server.

ericsciple added 3 commits January 21, 2020 01:29

fix ref for pr closed event when a pr is merged

25be3b7

.

57c5af9

.

77544dd

ericsciple commented Jan 21, 2020

View reviewed changes

TingluoHuang approved these changes Jan 21, 2020

View reviewed changes

ericsciple merged commit 090d9c9 into master Jan 21, 2020

ericsciple deleted the users/ericsciple/m165pr branch January 21, 2020 19:17

sync-by-unito bot mentioned this pull request Sep 24, 2021

Bump actions/checkout from 2 to 2.3.4 datastax/terraform-provider-astra#21

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix ref for pr closed event when a pr is merged #141

fix ref for pr closed event when a pr is merged #141

ericsciple commented Jan 21, 2020

ericsciple Jan 21, 2020

fix ref for pr closed event when a pr is merged #141

fix ref for pr closed event when a pr is merged #141

Conversation

ericsciple commented Jan 21, 2020

ericsciple Jan 21, 2020

Choose a reason for hiding this comment