Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

could not read Username for 'https://github.com': terminal prompts disabled #221

Closed
kolya182 opened this issue Apr 18, 2020 · 7 comments · Fixed by #278
Closed
Labels
bug Something isn't working

Comments

@kolya182
Copy link

Url to log https://github.com/trustwallet/assets/pull/1898/checks?check_run_id=597005450

name: Formatter
on:
  push:
    branches:
      - '*'
      - '!master'
  pull_request:
    branches:
      - 'master'
jobs:
  format:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
        with:
          ref: ${{ github.head_ref }}
          token: ${{ secrets.GITHUB_API_TOKEN }}
@ericsciple
Copy link
Contributor

Secrets aren't available to fork PRs.

The token input is empty. I confirmed by checking the log at the beginning of the checkout step. The token input isn't logged, which means it's empty.

@ericsciple
Copy link
Contributor

The checkout step should detect this case earlier and print a better error message.

@kolya182
Copy link
Author

Secrets aren't available to fork PRs.

The token input is empty. I confirmed by checking the log at the beginning of the checkout step. The token input isn't logged, which means it's empty.

Thank you for clarifying, after detailed reading I found this is has been an issue for many people to access secrets in forked PR in public repo (link1, link2)

@kolya182
Copy link
Author

kolya182 commented Apr 20, 2020

The checkout step should detect this case earlier and print a better error message.

Adding error message can be considered as a fix at this moment for this issue

@dentarg

This comment has been minimized.

@dentarg

This comment has been minimized.

@darknightm
Copy link

Hustle @humbleade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants