-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why the git 2.18 is required, there is no explanation in README #170
Comments
Checkout v2 was optimized to fetch a single commit - requires Git wire protocol v2. |
Is the alternative to use raw EDIT: We are testing git integration, so it's actually desirable to also use older versions. Does GitHub have any stats what versions of clients is used to access the site? |
@phadej Can I ask how you are updating Git? I'm using the
But this fails:
I'm having to do this because
I'm assuming that if I can upgrade it to |
@stevehobbsdev PPA works only with Ubuntu, and I currently use - name: Checkout
run: |
git clone --depth 1 https://github.com/$GITHUB_REPOSITORY.git .
git fetch origin $GITHUB_REF:temporary-ci-branch
git checkout $GITHUB_SHA step. It seems to work, but I'm quite sure I'm missing something. |
I'm experiencing this issue too.
@ericsciple The benefit of fetching a single commit clone is lost when using the |
@tariqc80 ubuntu-latest has Here is my workflow: on: push
jobs:
build:
runs-on: [ubuntu-latest]
steps:
- run: git --version Using branch + depth 1 is a race condition. The ref may move forward before the job begins, especially in workflows with a graph of jobs. |
...which is why checkout@v2 fetches the SHA instead |
@ericsciple Thanks for the response. I didn't realize that the job I was working with was using a container built from Debian Stretch; which ships with git v2.11. Now I understand the difference between |
As Ubuntu LTS-18.04 ships
git-1.17.1
this is a frustrating limitation, as one needs to updategit
in virtually any docker container used, when you care about having.git
folder present.The text was updated successfully, but these errors were encountered: