Make generated ffi portable, add 32bit support #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces several instance where we were using u64 or i64 as hard-coded instances for isize and usize with its dart counterparts of `UintPtr` and `IntPtr``. Thus rendering the generated dart file not only platform-compatible with the underlying target system, but also allowing us to the same generated dart file across any number of platforms. Prior to this for the few cases this was using usize-types, the generator would create a platform-specific mapping. As a result, we do now support 32bit targets as well.
This was referenced Jul 15, 2024
bitfriend
reviewed
Jul 17, 2024
Comment on lines
+43
to
+51
| #[cfg(target_pointer_width = "32")] | ||
| type IPtr = i32; | ||
| #[cfg(target_pointer_width = "32")] | ||
| type UPtr = i32; | ||
| #[cfg(target_pointer_width = "64")] | ||
| type IPtr = i64; | ||
| #[cfg(target_pointer_width = "64")] | ||
| type UPtr = i64; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces several instance where we were using
u64ori64as hard-coded instances forisizeandusizewith its dart counterparts ofUintPtrandIntPtr. Thus rendering the generated dart file not only platform-compatible with the underlying target system, but also allowing us to the same generated dart file across any number of platforms. Prior to this for the few cases this was using usize-types, the generator would create a platform-specific mapping.As a result, we do now support 32bit targets as well.