Fixing Workshop issues: Linking any Space & Chat, unlinking and tasks creation #2384

gnunicorn · 2024-11-24T16:54:31Z

While running the workshop the other day, we noticed some smaller bugs when going through the flow. This PR fixes them:

Fixes unlinking of chats wasn't working
You get prompted about activating the Tasks feature like with all other features, too

ask-to-activate-tasks-too.mp4

You can now link any Chat or any space as a "sub" one and we cleverly figure out whether that is "recommended" or "sub". This finishes the clean up of "recommended" vs "sub" and removes a bunch of artificial distinction between them for the UI, too

Linking-fixes.mp4

gnunicorn · 2024-11-24T16:54:59Z

app/lib/features/link_room/actions/unlink_child_room.dart

@@ -20,7 +20,7 @@ Future<void> unlinkChildRoom(
  await space.removeChildRoom(roomId, reason);
  //Fetch selected room data and add given parentSpaceId as parent
  final room = await ref.read(maybeRoomProvider(roomId).future);
-  if (room != null && room.isSpace()) {
+  if (room != null) {


this is what prevented the previous code from properly unlinking chats.

codecov · 2024-11-24T16:56:08Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.89%. Comparing base (d8d6bdf) to head (53f9ef7).
Report is 19 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2384      +/-   ##
==========================================
+ Coverage   27.34%   27.89%   +0.55%     
==========================================
  Files         604      607       +3     
  Lines       41888    41886       -2     
==========================================
+ Hits        11455    11685     +230     
+ Misses      30433    30201     -232

Flag	Coverage Δ
integration-test	`36.88% <ø> (ø)`
unittest	`20.00% <ø> (+0.79%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gnunicorn · 2024-11-24T16:56:11Z

app/lib/features/link_room/pages/link_room_page.dart

@@ -0,0 +1,205 @@
+import 'package:acter/common/extensions/options.dart';


the core structure of these has remained the same, but they appears a new files because I moved the content into its own feature and split it up into several distinct widgets that I can also easier test on their own.

gnunicorn · 2024-11-24T16:57:03Z

app/lib/features/link_room/pages/link_room_page.dart

+class _LinkRoomPageConsumerState extends ConsumerState<LinkRoomPage> {
+  final TextEditingController searchTextEditingController =
+      TextEditingController();
+


removed a bunch of stateful ness here that could be done with providers instead. Later realized that we can even collapse most of these providers.

gnunicorn · 2024-11-24T16:57:41Z

app/lib/features/link_room/types.dart

+// ChildRoomType configures the sub child type of the `Spaces`
+enum ChildRoomType {
+  chat,
+  space,


removed the "recommneded" type as we consider all of them the same, it is really just a question of which listing provider we are using.

gnunicorn · 2024-11-24T16:58:43Z

app/lib/features/link_room/widgets/link_room_trailing.dart

+    final room = await ref.read(maybeRoomProvider(roomId).future);
+    if (room == null) {
+      EasyLoading.showError(lang.roomNotFound);
+      return;
+    }
+
+    final canLink = (await ref.read(roomMembershipProvider(roomId).future))
+            ?.canString('CanLinkSpaces') ==
+        true;
+
+    //Fetch selected parent space data and add given roomId as child
+    final space = await ref.read(spaceProvider(parentId).future);
+    await space.addChildRoom(roomId, false);
+
+    //Make subspace
+    if (canLink) {
+      //Fetch selected room data and add given parentSpaceId as parent
+      await room.addParentRoom(parentId, true);
+      if (!context.mounted) return;
+      await checkJoinRule(context, ref, room, parentId);
+    } else {
+      EasyLoading.showSuccess(lang.roomLinkedButNotUpgraded);
+    }


This now accepts both the non upgradable and the uprgadable cases and only shows the dialog if you can upgrade. If you can't uprgade you'll get a success messages with a note instead.

gnunicorn · 2024-11-24T16:59:52Z

app/lib/features/space/widgets/space_sections/space_actions_section.dart

-          iconData: Atlas.list,
-          title: lang.addTask,
-          onPressed: () async {
-            if (!canAddEvent && canChangeSetting) {


this was the actual bug. canAddEvent is the wrong check here. However, while looking at it, I also noticed that we are only checking the permission but not if the feature is activated, so I did refactor the entire file to check for the feature-activation more specifically.

gnunicorn · 2024-11-24T17:00:17Z

app/test/features/link_room/link_room_page_test.dart

@@ -0,0 +1,147 @@
+import 'package:acter/common/providers/chat_providers.dart';


yay tests \o/ !

gtalha07 · 2024-11-26T10:46:57Z

app/lib/features/link_room/widgets/link_room_trailing.dart

+    );
+  }
+
+  Future<void> checkJoinRule(


This can be moved over created actions folder along with other methods

I was thinking about it but consider this very specific to this flow at the moment and rather not have this be reusable for others yet ...

gtalha07

Looks good!

gnunicorn added 8 commits November 24, 2024 12:49

Fix asking to activate tasks feature when showing the button

e0fca66

Add tests for link room page

6b36563

Refactor space linking page for better usability

57fc5ad

Refactor into separate link room feature

85fb2f0

Link Widget tests: fix unlinking of chats

a78540f

Add ability to link rooms you aren't admin of with message

45d4684

Generalize Space List item, allow chats to be linked, too

613ce77

Changelog

3cfe973

gnunicorn added bug Something isn't working flutter labels Nov 24, 2024

gnunicorn requested review from kumarpalsinh25 and gtalha07 November 24, 2024 16:54

gnunicorn commented Nov 24, 2024

View reviewed changes

Fixing fmt

53f9ef7

gtalha07 reviewed Nov 26, 2024

View reviewed changes

gtalha07 approved these changes Nov 26, 2024

View reviewed changes

gnunicorn merged commit 4e0dacf into main Nov 26, 2024
23 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing Workshop issues: Linking any Space & Chat, unlinking and tasks creation #2384

Fixing Workshop issues: Linking any Space & Chat, unlinking and tasks creation #2384

gnunicorn commented Nov 24, 2024

gnunicorn Nov 24, 2024

codecov bot commented Nov 24, 2024 •

edited

Loading

gnunicorn Nov 24, 2024

gnunicorn Nov 24, 2024

gnunicorn Nov 24, 2024

gnunicorn Nov 24, 2024

gnunicorn Nov 24, 2024

gnunicorn Nov 24, 2024

gtalha07 Nov 26, 2024 •

edited

Loading

gnunicorn Nov 26, 2024

gtalha07 left a comment

		@@ -0,0 +1,205 @@
		import 'package:acter/common/extensions/options.dart';

		@@ -0,0 +1,147 @@
		import 'package:acter/common/providers/chat_providers.dart';

Fixing Workshop issues: Linking any Space & Chat, unlinking and tasks creation #2384

Fixing Workshop issues: Linking any Space & Chat, unlinking and tasks creation #2384

Conversation

gnunicorn commented Nov 24, 2024

Choose a reason for hiding this comment

codecov bot commented Nov 24, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gtalha07 Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gtalha07 left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 24, 2024 •

edited

Loading

gtalha07 Nov 26, 2024 •

edited

Loading