Deep linking setup #2360

gnunicorn · 2024-11-10T13:07:26Z

This PR brings the infrastructure for deep-linking -- aka opening the App with custom provided links -- to Acter. Additionally, these links can also be shared via QR-Code and a corresponding QR-parsing facility is included.

Here as if a link was clicked:

PXL_20241122_164942060.TS.mp4

With QR code reader:

PXL_20241122_165422382.TS.mp4

Opening super invite via QR code:

PXL_20241122_165549728.TS.mp4

refs #2223 :

In particular this PR does:

codecov · 2024-11-10T15:44:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.37%. Comparing base (d8d6bdf) to head (0f0827a).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2360      +/-   ##
==========================================
+ Coverage   27.34%   27.37%   +0.02%     
==========================================
  Files         604      613       +9     
  Lines       41888    42167     +279     
==========================================
+ Hits        11455    11543      +88     
- Misses      30433    30624     +191

Flag	Coverage Δ
integration-test	`36.88% <ø> (ø)`
unittest	`19.32% <ø> (+0.11%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

Currently translated at 100.0% (1135 of 1135 strings) Translation: Acter/App Translate-URL: http://weblate.acter.global/projects/acter-app/flutter-app/de/

gnunicorn · 2024-11-22T17:09:17Z

app/lib/features/deep_linking/utils.dart

+
+class ParsingFailed extends UriParseError {}
+
+UriParseResult parseUri(Uri uri) => switch (uri.scheme) {


Highly wrapped code, but just check the unit tests to understand the formats and what it does ...

gnunicorn · 2024-11-22T17:13:12Z

app/lib/features/main/providers/main_providers.dart

 import 'package:flutter_riverpod/flutter_riverpod.dart';

 final quickActionVisibilityProvider =
    StateProvider.autoDispose<bool>((ref) => false);
+
+final appLinks = AppLinks(); // AppLinks is singleton


global setup according to applinks plugin

gnunicorn · 2024-11-22T17:14:11Z

app/lib/features/main/widgets/bottom_navigation_widget.dart

@@ -41,7 +41,7 @@ class BottomNavigationWidget extends ConsumerWidget {
                bottomNavNar(ref),
                AnimatedContainer(
                  duration: const Duration(milliseconds: 300),
-                  height: showQuickActions ? 150 : 0,
+                  height: showQuickActions ? 180 : 0,


slightly more space for our new bottom bar.

gnunicorn · 2024-11-22T17:15:29Z

app/lib/features/settings/pages/settings_page.dart

+    return InkWell(
+      onTap: () => shouldGoReplacement
+          ? context.pushReplacementNamed(Routes.myProfile.name)
+          : context.pushNamed(Routes.myProfile.name),
+      child: Card(
+        shape: RoundedRectangleBorder(
+          borderRadius: BorderRadius.circular(16),
+        ),
+        child: Column(
+          children: [
+            ListTile(
+              leading: ActerAvatar(
+                options: AvatarOptions.DM(accountInfo),
+              ),


Refactorted the UserHeader card a bit for usability:

trailing now has the QR-code button

the entire area is now clickable to get into the profile edit

gnunicorn · 2024-11-22T17:16:27Z

app/lib/features/users/actions/show_global_user_dialog.dart

+import 'package:acter/features/users/widgets/user_info_drawer.dart';
+import 'package:flutter/material.dart';
+
+const Key userInfoDrawer = Key('users-widgets-user-info-drawer');


mostly copy of the member-info-drawer section but adapted to our profile (which might even be missing) and doesn't have any room.

gnunicorn · 2024-11-22T17:16:49Z

app/lib/features/users/providers/user_profile_provider.dart

+final globalUserProfileProvider =
+    FutureProvider.family<UserProfile?, String>((ref, userId) async {
+  final client = ref.watch(alwaysClientProvider);
+  return (await client.searchUsers(userId)).toList().firstOrNull;


trying to find a user-id without any additional info goes over the search.

gnunicorn · 2024-11-22T17:17:20Z

app/lib/features/users/widgets/message_user_button.dart

@@ -10,18 +10,20 @@ import 'package:flutter_riverpod/flutter_riverpod.dart';
 import 'package:go_router/go_router.dart';

 class MessageUserButton extends ConsumerWidget {


moved and simplified to work in both room-member and global-user-scenarios ...

gnunicorn · 2024-11-22T17:17:56Z

app/lib/features/users/widgets/user_info_drawer.dart

+
+final _log = Logger('a3::user::user_info_drawer');
+
+class _UserInfoDrawerInner extends ConsumerWidget {


mostly a copy of the member_info_drawer. Just simplified and removed a few things we never have here.

gnunicorn · 2024-11-22T17:20:07Z

app/test/features/deep_linking/parsing_test.dart

+import 'package:acter/features/deep_linking/utils.dart';
+import 'package:flutter_test/flutter_test.dart';
+
+void main() {


these are all the parsing tests

gnunicorn added 8 commits November 10, 2024 15:42

Add app links

35e45c1

Add Android config

b9c7c10

Disable in iOS setup

d296637

Setup Windows App Linking

1e36753

MacOS deep link support

09922ef

Linux support for custom schemes

8fb704d

Move AppShell

dd016e3

Print deep linked for testing

34e9130

gnunicorn force-pushed the ben-deep-linking-setup branch from 1c9a95c to 34e9130 Compare November 10, 2024 15:42

gnunicorn and others added 20 commits November 10, 2024 16:30

DeepLinking parsing matrix:-uri

243687e

Add support for matrix.to urls

54ea8fb

acter object links

6f8582e

Merge remote-tracking branch 'origin/main' into ben-deep-linking-setup

ed8100f

super invite support

7e4f0e5

qr-code support for invites

6c83521

User QRcode

39245e7

space access qrcode

d84f1da

QRcode reading

cecb9ec

dart fixup

461676b

Add info preview support on parser

3ec15d4

Reedeeming Super Invites UI support

2322195

New Build Certs export

d45f0c4

Translated using Weblate (German)

aa01f93

Currently translated at 100.0% (1135 of 1135 strings) Translation: Acter/App Translate-URL: http://weblate.acter.global/projects/acter-app/flutter-app/de/

Fixes, #2356

4ba4fee

Fixes, #2362

fad03ba

Fixes, #1704

c4deaae

Fixes,#2351

9055878

Fixes, #2358

3543a5d

Add changelog data

4d7bc2a

kumarpalsinh25 and others added 19 commits November 22, 2024 15:25

Minor Correction

b75ae09

Minor Typo Correction

d6d28de

Minor code formating optimisation

b6ac04e

Better management of event section header on dashboard

b1f7104

Lint error fixes

22e4216

Test ensuring empty section of spaces list renders fine

92e0785

Rename Front -> First

f624515

Test ensuring our space search works find

17a96ef

Simplifying refactor

6aafce0

Releasing v1.24.11140

4f2616e

Mac App Certificates

4a5466e

Merge remote-tracking branch 'origin/main' into ben-deep-linking-setup

19e10fd

User Id sharing and parsing support

ddc26fa

Also react to matrix.to-links

543a0ba

Wire up uri parsing code with incoming activities

e293596

Fixup switch check format

6ca5d1d

Disable space QR button

ebe12b4

Also react to matrix.to-links

ad26a66

Fix l10n, formatting

db5fd55

gnunicorn commented Nov 22, 2024

View reviewed changes

gnunicorn marked this pull request as ready for review November 22, 2024 17:25

fixing buildcontext gapping

dc1e625

gnunicorn requested review from kumarpalsinh25, bitfriend and gtalha07 and removed request for bitfriend and kumarpalsinh25 November 22, 2024 17:34

Add Changelog

0f0827a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deep linking setup #2360

Deep linking setup #2360

gnunicorn commented Nov 10, 2024 •

edited

Loading

codecov bot commented Nov 10, 2024 •

edited

Loading

gnunicorn Nov 22, 2024

gnunicorn Nov 22, 2024

gnunicorn Nov 22, 2024

gnunicorn Nov 22, 2024

gnunicorn Nov 22, 2024

gnunicorn Nov 22, 2024

gnunicorn Nov 22, 2024

gnunicorn Nov 22, 2024

gnunicorn Nov 22, 2024


		class ParsingFailed extends UriParseError {}

		UriParseResult parseUri(Uri uri) => switch (uri.scheme) {

		@@ -10,18 +10,20 @@ import 'package:flutter_riverpod/flutter_riverpod.dart';
		import 'package:go_router/go_router.dart';

		class MessageUserButton extends ConsumerWidget {


		final _log = Logger('a3::user::user_info_drawer');

		class _UserInfoDrawerInner extends ConsumerWidget {

Deep linking setup #2360

Are you sure you want to change the base?

Deep linking setup #2360

Conversation

gnunicorn commented Nov 10, 2024 • edited Loading

codecov bot commented Nov 10, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gnunicorn commented Nov 10, 2024 •

edited

Loading

codecov bot commented Nov 10, 2024 •

edited

Loading