Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated "Scrollable content can be reached with sequential focus navigation" [0ssw9k]: scrollable regions pass when there is an open modal #2219

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

giacomo-petri
Copy link
Collaborator

Closes issue(s): #2217

This update addresses scrollable elements that become inert, such as when overlaid by modals. The update includes:

  • A revision of the expectation to exclude inert scrollable elements from sequential focus.
  • An added passing example that illustrates this adjustment.

Need for Call for Review:
This will require a 2 weeks Call for Review


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

- updated expectation to exclude inert elements from sequential focus
- added passing example
Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Missing a link.

_rules/scrollable-element-keyboard-accessible-0ssw9k.md Outdated Show resolved Hide resolved
_rules/scrollable-element-keyboard-accessible-0ssw9k.md Outdated Show resolved Hide resolved
Copy link
Member

@carlosapaduarte carlosapaduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about two lines in the example that don't seem to be needed.

<script>
const openDialog = () => {
ppDialog.showModal();
myFrame.tabIndex = '-1'
Copy link
Member

@carlosapaduarte carlosapaduarte Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this line (and line 149)?
I don't think so, but just wanting to make sure.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention was to create a real case scenario, but I’m fine with removing them if we believe they could cloud the outcome.

@giacomo-petri giacomo-petri requested a review from Jym77 October 25, 2024 08:05
@giacomo-petri
Copy link
Collaborator Author

Call for review ends November 20th

@giacomo-petri giacomo-petri added the Review call 2 weeks Call for review for new rules and big changes label Nov 5, 2024
@WilcoFiers WilcoFiers merged commit e17ea0c into develop Nov 21, 2024
2 checks passed
@WilcoFiers WilcoFiers deleted the giacomo-petri-scrollable-regions-modal branch November 21, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review call 2 weeks Call for review for new rules and big changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants