-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated "Scrollable content can be reached with sequential focus navigation" [0ssw9k]: scrollable regions pass when there is an open modal #2219
Conversation
- updated expectation to exclude inert elements from sequential focus - added passing example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Missing a link.
Co-authored-by: Jean-Yves Moyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment about two lines in the example that don't seem to be needed.
<script> | ||
const openDialog = () => { | ||
ppDialog.showModal(); | ||
myFrame.tabIndex = '-1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this line (and line 149)?
I don't think so, but just wanting to make sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention was to create a real case scenario, but I’m fine with removing them if we believe they could cloud the outcome.
Call for review ends November 20th |
Closes issue(s): #2217
This update addresses scrollable elements that become inert, such as when overlaid by modals. The update includes:
Need for Call for Review:
This will require a 2 weeks Call for Review
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve