Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak definition of focusable #2210

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Tweak definition of focusable #2210

merged 4 commits into from
Nov 21, 2024

Conversation

tombrunet
Copy link
Collaborator

@tombrunet tombrunet commented Aug 1, 2024

The current definition exception for immediately losing focus was added due to modal bumpers / focus sentinels. However, if focus is pulled from an item and immediately put back, this definition would consider it as not focusable since it will lose focus. This proposes adjusting the definition to ignore the exception if focus is regained.

Closes issue(s):

Need for Call for Review:
This will require a 1 week Call for Review


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@tombrunet tombrunet self-assigned this Aug 1, 2024
@tombrunet tombrunet marked this pull request as ready for review August 1, 2024 16:53
Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have an example of this in one of the "focus" rules.

@WilcoFiers WilcoFiers merged commit f9eace3 into develop Nov 21, 2024
2 checks passed
@WilcoFiers WilcoFiers deleted the focus-def-refocus branch November 21, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants