-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Form field has non-empty accessible name [e086e5]: Added secondary requirements for 1.3.1 and 2.5.3 #2188
Merged
Jym77
merged 5 commits into
develop
from
giacomo-petri-e086e5-added-secondary-requirements
Aug 1, 2024
Merged
Update Form field has non-empty accessible name [e086e5]: Added secondary requirements for 1.3.1 and 2.5.3 #2188
Jym77
merged 5 commits into
develop
from
giacomo-petri-e086e5-added-secondary-requirements
Aug 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jym77
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typos, approving already.
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
WilcoFiers
approved these changes
Jun 28, 2024
kengdoj
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found a typo.
Co-authored-by: Kathy Eng <[email protected]>
kengdoj
approved these changes
Jul 16, 2024
giacomo-petri
added
Review call 2 weeks
Call for review for new rules and big changes
and removed
reviewers wanted
labels
Jul 17, 2024
Call for reviews ends on Aug 1st. |
carlosapaduarte
approved these changes
Jul 17, 2024
ronsmantpg
approved these changes
Jul 18, 2024
Call for review has ended, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue(s): #2166
Updates:
Need for Call for Review:
This will require a 2 weeks Call for Review
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve