Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sources in inapplicable example 2 (4c31df) #2158

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Update sources in inapplicable example 2 (4c31df) #2158

merged 4 commits into from
Apr 25, 2024

Conversation

carlosapaduarte
Copy link
Member

Source files pointed at in inapplicable example 2 were incorrect (they have audio, which makes them applicable). Correct to use the same source files used in the composite rule.

Closes issue(s):

Need for Call for Review:

  • This will require a 1 week Call for Review

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@carlosapaduarte carlosapaduarte added Rule Update Use this label for an existing rule that is being updated reviewers wanted labels Feb 5, 2024
@carlosapaduarte carlosapaduarte self-assigned this Feb 5, 2024
@carlosapaduarte carlosapaduarte changed the title Update sources in inapplicable example 2 Update sources in inapplicable example 2 (4c31df) Feb 5, 2024
@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Apr 18, 2024
@Jym77
Copy link
Collaborator

Jym77 commented Apr 18, 2024

Call for review ends on April 25th.

@Jym77
Copy link
Collaborator

Jym77 commented Apr 25, 2024

Call for review has ended, merging.

@Jym77 Jym77 merged commit 413e317 into develop Apr 25, 2024
2 checks passed
@Jym77 Jym77 deleted the fix-4c31df branch April 25, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated
Projects
None yet
4 participants