Fix missing definition aria-state-or-property-valid-value-6a7281 #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kengdoj
approved these changes
Oct 24, 2023
tbostic32
approved these changes
Oct 24, 2023
HelenBurge
approved these changes
Oct 25, 2023
Jym77
approved these changes
Oct 26, 2023
| @@ -244,3 +245,4 @@ The `aria-hidden` attribute is not on an [HTML or SVG element][]. | |||
| [html or svg element]: #namespaced-element | |||
| [value type]: https://www.w3.org/TR/wai-aria-1.2/#propcharacteristic_value | |||
| [wai-aria state or property]: https://www.w3.org/TR/wai-aria-1.2/#state_prop_def | |||
| [attribute value]: #attribute-value | |||
There was a problem hiding this comment.
I'm curious how this passed tests if the [attribute value] ref was missing 🤔 Are we having flaky tests?
There was a problem hiding this comment.
The tests check that an ID exists. If there's no ID then it's ignored. We could definitely do with an extra test to prevent this if you're up for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need for Call for Review: none, editorial
How to Review And Approve