Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarified and included CJK requirements in large text definition and updated rules affected by this change #2121
Clarified and included CJK requirements in large text definition and updated rules affected by this change #2121
Changes from 22 commits
a316f03
fcc0409
4f781a0
4456dec
a60cf76
54ffbd6
39a211d
5cac272
546a5a3
3107c19
c9889a7
4aaa207
ab17360
00b0cca
1834876
6aaa18d
a8d6293
61d9e74
2724569
7fcae63
41aba7f
66e806c
9934e03
4ded309
44b691b
caaa73a
2f0e977
70bb0cc
b9cda2d
8b1c88a
03cf3d3
9063dba
b412651
33b28d6
3f89a93
221799d
d08ce97
3bacb00
520f01c
7d4f76d
eace061
496f0bf
2196334
0b622d5
e7e290f
bbf55cb
eaa3902
cf72047
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some of the new examples should be in Korean or Chinese instead of Japanese. Not blocking, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jym77,
I've made some revisions to the examples by substituting Japanese with Chinese, utilizing the Chinese rendition of the WCAG 2.1 title.
Regarding Korean, it appears that only "Hanja" (Chinese characters) are affected by this rule. However, given my unqualified Korean language knowledge, I'm unable to craft a meaningful sentence using these Hanja characters. Any assistance from the community in providing a valid Korean sentence would be greatly appreciated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Korean Hangul might be another special case - lines are laid out in 2 dimensions unlike Chinese and Japanese (or European languages). It's unclear what point size and line height mean for Hangul layout.
The 꿀벌 above are are actually 2 groups of 3 characters stacked vertically (one group for each syllable).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like Korean Hanja is very rare - its use and teaching was banned in 1968 - so we can probably ignore it. The ban has been repealed recently, but as a result most Korean people don't know Hanja:
https://en.wikipedia.org/wiki/Hanja#Decline_of_Hanja
The Hangul syllable blocks mentioned in the comment above are precomposed into 11,000+ Unicode code points so point size is the size of the precomposed glyph.
https://www.w3.org/TR/klreq/#hangulcodes
This is similar to the way accents like circumflex and vowels are precomposed Unicode code points in French, as in the letter ô in hôpital
The Hangul Jamo code points can be combined into single glyphs representing a syllable. This is similar to how the letter 'o' U+006F and combining circumflex '◌̂' U+0302 can be composed into the glyph ô
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed Example 15
This 16pt bold black Traditional Chinese text has a contrast ratio of 3.6:1 on the gray background.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed Example 14
This 20pt black Traditional Chinese text has a contrast ratio of 4.6:1 on the gray background.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rewrote a few things, including updating the links as I found this a little difficult to read with all the URLs in them:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taiwan has different requirements than Japan, I propose the following:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: I think we should rephrase the full definition (as it doesn't look like correct English now), in the line of:
Maybe even start the definition with "depending whether the text node contains CJK characters, …" 🤔
Also, if the defined term instances (
_large scale text_
) are wrapped in adfn
element, we can reference them directly from the running text:See, e.g. attribute value in image button name rule
Additionally (but not directly related to this PR, so may be taken separately):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions applied rewriting the definition and starting with "A text node..."
Happy to edit condition lists and include them in the current edits.
You're absolutely right. This was the case in the previous iteration as well. I'm struggling to find a straightforward method to enhance its clarity without adding more complexity to the definition.
updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that an unofficial translation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed it while accepting Wilco suggestion. Good catch.
Updated