From c77612f44634e8c828b0abf2d754a5a01394dac6 Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Thu, 27 Jul 2023 11:50:46 +0200 Subject: [PATCH 1/3] Update element-lang-valid-de46e4.md Updated Failed examples 4 and 5 to reflect applicability --- _rules/element-lang-valid-de46e4.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/_rules/element-lang-valid-de46e4.md b/_rules/element-lang-valid-de46e4.md index fe5e3127429..1414949253c 100755 --- a/_rules/element-lang-valid-de46e4.md +++ b/_rules/element-lang-valid-de46e4.md @@ -184,7 +184,7 @@ This `article` element has a `lang` [attribute value][] which consists of only [ #### Failed Example 4 -The `lang` [attribute value][] does not have a valid language tag. The `lang` attribute must be valid because the content is [visible][]. +The `lang` [attribute value][] does not have a valid language tag. Even though its descendant `p` element is not [included in the accessibility tree][] due to the presence of the `aria-hidden="true"` attribute, the content of the `p` element is still [text inheriting its programmatic language][] from the `article` element. Hence, the lang attribute must be valid. ```html @@ -200,7 +200,7 @@ The `lang` [attribute value][] does not have a valid language tag. The `lang` at #### Failed Example 5 -The `lang` [attribute value][] does not have a valid language tag, and its [descendant][] is not [visible][] though it is still [included in the accessibility tree][]. +The `lang` [attribute value][] does not have a valid language tag. Even though its descendant `p` element is not [visible][] due to the CSS properties set, the content of the `p` element is still [text inheriting its programmatic language][] from the `article` element. Hence, the lang attribute must be valid. ```html From 3ab7435a77f06dae10fa2d455a0ed53178f59ae4 Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Thu, 31 Aug 2023 11:28:43 +0200 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: Jean-Yves Moyen --- _rules/element-lang-valid-de46e4.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/_rules/element-lang-valid-de46e4.md b/_rules/element-lang-valid-de46e4.md index 1414949253c..2095d9a7f54 100755 --- a/_rules/element-lang-valid-de46e4.md +++ b/_rules/element-lang-valid-de46e4.md @@ -184,7 +184,7 @@ This `article` element has a `lang` [attribute value][] which consists of only [ #### Failed Example 4 -The `lang` [attribute value][] does not have a valid language tag. Even though its descendant `p` element is not [included in the accessibility tree][] due to the presence of the `aria-hidden="true"` attribute, the content of the `p` element is still [text inheriting its programmatic language][] from the `article` element. Hence, the lang attribute must be valid. +The `lang` [attribute value][] does not have a valid language tag. Even though the `p` element is not [included in the accessibility tree][] due to the presence of the `aria-hidden="true"` attribute, it is [visible][]; therefore its content is [text inheriting its programmatic language][] from the `article` element. Hence, the lang attribute must be valid. ```html @@ -200,7 +200,7 @@ The `lang` [attribute value][] does not have a valid language tag. Even though i #### Failed Example 5 -The `lang` [attribute value][] does not have a valid language tag. Even though its descendant `p` element is not [visible][] due to the CSS properties set, the content of the `p` element is still [text inheriting its programmatic language][] from the `article` element. Hence, the lang attribute must be valid. +The `lang` [attribute value][] does not have a valid language tag. Even though the `p` element is not [visible][] due to the being moved off-screen, it is [included in the accessibility tree][]; therefore its content is [text inheriting its programmatic language][] from the `article` element. Hence, the lang attribute must be valid. ```html From d1cb770d3734cb625f08574b613a07d446397684 Mon Sep 17 00:00:00 2001 From: Giacomo Petri <106394951+giacomo-petri@users.noreply.github.com> Date: Wed, 6 Sep 2023 09:26:16 +0200 Subject: [PATCH 3/3] Update _rules/element-lang-valid-de46e4.md Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com> --- _rules/element-lang-valid-de46e4.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_rules/element-lang-valid-de46e4.md b/_rules/element-lang-valid-de46e4.md index 2095d9a7f54..a082a06449e 100755 --- a/_rules/element-lang-valid-de46e4.md +++ b/_rules/element-lang-valid-de46e4.md @@ -200,7 +200,7 @@ The `lang` [attribute value][] does not have a valid language tag. Even though t #### Failed Example 5 -The `lang` [attribute value][] does not have a valid language tag. Even though the `p` element is not [visible][] due to the being moved off-screen, it is [included in the accessibility tree][]; therefore its content is [text inheriting its programmatic language][] from the `article` element. Hence, the lang attribute must be valid. +The `lang` [attribute value][] does not have a valid language tag. Even though the `p` element is not [visible][] due to it being moved off-screen, it is [included in the accessibility tree][]; therefore its content is [text inheriting its programmatic language][] from the `article` element. Hence, the lang attribute must be valid. ```html