From b59bcd3c482b9c9f1d6dc122d939357cfd9e368c Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Tue, 17 Jan 2023 10:34:05 +0100 Subject: [PATCH 01/20] Update programmatically-determined-link-context.md --- pages/glossary/programmatically-determined-link-context.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pages/glossary/programmatically-determined-link-context.md b/pages/glossary/programmatically-determined-link-context.md index 770b1745042..429f9ab67b7 100755 --- a/pages/glossary/programmatically-determined-link-context.md +++ b/pages/glossary/programmatically-determined-link-context.md @@ -16,6 +16,8 @@ The _programmatically determined context_ of a link (or _programmatically determ - being a header cell [assigned][] to the closest [ancestor][] of the link in the [flat tree][] that has a [semantic role][] of `cell` or `gridcell`; or - being referenced by an `aria-describedby` attribute of the link. +**Note**: Since screen readers interpret punctuation, they can also provide the context from the current sentence, when the focus is on a link in that sentence. + This definition is based on the [WCAG definition of programmatically determined link context](https://www.w3.org/TR/WCAG21/#dfn-programmatically-determined-link-context). This definition assumes that the HTML document with the link is a document using HTML according to the specification. From 63bd55fcc2cfaf4fe6148aa1fcc3ee68936b13a0 Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Thu, 23 Feb 2023 19:37:59 +0100 Subject: [PATCH 02/20] Update iframe-not-focusable-has-no-interactive-content-akn7bn.md --- ...sable-has-no-interactive-content-akn7bn.md | 27 ++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md index e31dbad86f7..efe5c0dba75 100755 --- a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md +++ b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md @@ -28,13 +28,17 @@ acknowledgments: ## Applicability -This rule applies to any `iframe` element that [contains](#akn7bn:contain) at least one element for which all the following are true: +This rule applies to any `iframe` element that is not [inert](#akn7bn:inert) and that [contains](#akn7bn:contain) at least one element for which all the following are true: - the element is [visible][]; and - the element is part of the [sequential focus navigation order][] of the `iframe`'s [document][]. An element is contained in a [nested browsing context][] if its [owner document][] is the [container document][] of the [nested browsing context][]. +An `iframe` element is inert if: +- it has an `inert` [attribute value][] of true; or +- an element which is not the iframe itself and that is not [contained](#akn7bn:contain) in it behaves as a modal, making the iframe inoperable. + ## Expectation The test target does not have a negative number as a `tabindex` [attribute value][]. @@ -122,6 +126,27 @@ This `iframe` element contains a link that is not part of its [sequential focus ``` +#### Inapplicable Example 5 + +This `iframe` element is [inert][] because of its own `inert` [attribute value][]. + +```html + +``` + +#### Inapplicable Example 5 + +This `iframe` element is [inert][] because of another element that behaves as a modal. + +```html +
+
+ +

Hello World!

+
+ +``` + [attribute value]: #attribute-value 'Definition of Attribute Value' [container document]: https://html.spec.whatwg.org/#bc-container-document 'HTML browsing context container document, 2020/12/18' [document]: https://html.spec.whatwg.org/multipage/dom.html#document 'HTML definition of document' From 9c05f21d5e2ba4a6e1b44ec4f427a7452bebe2da Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Thu, 23 Feb 2023 19:51:00 +0100 Subject: [PATCH 03/20] Update programmatically-determined-link-context.md --- pages/glossary/programmatically-determined-link-context.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/pages/glossary/programmatically-determined-link-context.md b/pages/glossary/programmatically-determined-link-context.md index 429f9ab67b7..770b1745042 100755 --- a/pages/glossary/programmatically-determined-link-context.md +++ b/pages/glossary/programmatically-determined-link-context.md @@ -16,8 +16,6 @@ The _programmatically determined context_ of a link (or _programmatically determ - being a header cell [assigned][] to the closest [ancestor][] of the link in the [flat tree][] that has a [semantic role][] of `cell` or `gridcell`; or - being referenced by an `aria-describedby` attribute of the link. -**Note**: Since screen readers interpret punctuation, they can also provide the context from the current sentence, when the focus is on a link in that sentence. - This definition is based on the [WCAG definition of programmatically determined link context](https://www.w3.org/TR/WCAG21/#dfn-programmatically-determined-link-context). This definition assumes that the HTML document with the link is a document using HTML according to the specification. From 452504a9955e0ee76f08f41ac88f02a24e27c6fe Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Fri, 24 Feb 2023 09:31:06 +0100 Subject: [PATCH 04/20] Update iframe-not-focusable-has-no-interactive-content-akn7bn.md --- .../iframe-not-focusable-has-no-interactive-content-akn7bn.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md index efe5c0dba75..43e17805666 100755 --- a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md +++ b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md @@ -134,7 +134,7 @@ This `iframe` element is [inert][] because of its own `inert` [attribute value][ ``` -#### Inapplicable Example 5 +#### Inapplicable Example 6 This `iframe` element is [inert][] because of another element that behaves as a modal. From 349c1e3513643226b8ba17c569d837fd7eaf199a Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Fri, 24 Feb 2023 09:53:36 +0100 Subject: [PATCH 05/20] Create modal-dialog --- pages/glossary/modal-dialog | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 pages/glossary/modal-dialog diff --git a/pages/glossary/modal-dialog b/pages/glossary/modal-dialog new file mode 100644 index 00000000000..0ac25e11820 --- /dev/null +++ b/pages/glossary/modal-dialog @@ -0,0 +1,16 @@ +--- +title: Modal dialog +key: modal-dialog +unambiguous: true +objective: true +input_aspects: + - Accessibility tree + - CSS styling + - DOM tree +--- + +A modal dialog is a type of user interface element that appears on top of the main content of a [html web page][] or application and requires the user to take some action or make a decision before they can continue interacting with the program. + +Modal dialogs are typically used to display important messages, prompts, or alerts that require the user's attention and prevent them from interacting with other parts of the page until they have addressed the issue at hand. They are "modal" because they create a temporary mode where the user is focused on the dialog and cannot interact with the rest of the page. + +[html web page]: #web-page-html 'Definition of Web Page' From eb95290e379628ce41e0d930345e1fb407f33cd4 Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Fri, 24 Feb 2023 09:54:31 +0100 Subject: [PATCH 06/20] Rename modal-dialog to modal-dialog.md --- pages/glossary/{modal-dialog => modal-dialog.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename pages/glossary/{modal-dialog => modal-dialog.md} (100%) diff --git a/pages/glossary/modal-dialog b/pages/glossary/modal-dialog.md similarity index 100% rename from pages/glossary/modal-dialog rename to pages/glossary/modal-dialog.md From 149bca2c7e197eab7b78f59e2b6a4556170dfaba Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Fri, 24 Feb 2023 09:55:57 +0100 Subject: [PATCH 07/20] Update iframe-not-focusable-has-no-interactive-content-akn7bn.md --- .../iframe-not-focusable-has-no-interactive-content-akn7bn.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md index 43e17805666..f29179a5599 100755 --- a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md +++ b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md @@ -37,7 +37,7 @@ An element is contained in a [nested browsing con An `iframe` element is inert if: - it has an `inert` [attribute value][] of true; or -- an element which is not the iframe itself and that is not [contained](#akn7bn:contain) in it behaves as a modal, making the iframe inoperable. +- an element which is not the iframe itself and that is not [contained](#akn7bn:contain) in it behaves as a [modal][], making the iframe inoperable. ## Expectation @@ -151,6 +151,7 @@ This `iframe` element is [inert][] because of another element that behaves as a [container document]: https://html.spec.whatwg.org/#bc-container-document 'HTML browsing context container document, 2020/12/18' [document]: https://html.spec.whatwg.org/multipage/dom.html#document 'HTML definition of document' [flattened tabindex-ordered focus navigation scope]: https://html.spec.whatwg.org/multipage/interaction.html#flattened-tabindex-ordered-focus-navigation-scope 'HTML - Living Standard, 2022/07/08' +[modal-dialog]: #modal-dialog 'Definition of Modal dialog' [nested browsing context]: https://html.spec.whatwg.org/#nested-browsing-context 'HTML nested browsing context, 2020/12/18' [owner document]: https://dom.spec.whatwg.org/#dom-node-ownerdocument 'DOM node owner document property, 2020/12/18' [sc211]: https://www.w3.org/TR/WCAG21/#keyboard 'WCAG 2.1 Success criterion 2.1.1 Keyboard' From cc8411de2db88410f7937043781b4e0acf1b0dde Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Fri, 24 Feb 2023 10:04:38 +0100 Subject: [PATCH 08/20] Update iframe-not-focusable-has-no-interactive-content-akn7bn.md --- .../iframe-not-focusable-has-no-interactive-content-akn7bn.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md index f29179a5599..b0ce629aa6a 100755 --- a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md +++ b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md @@ -136,7 +136,7 @@ This `iframe` element is [inert][] because of its own `inert` [attribute value][ #### Inapplicable Example 6 -This `iframe` element is [inert][] because of another element that behaves as a modal. +This `iframe` element is [inert][] because of another element that behaves as a [modal][]. ```html
@@ -151,7 +151,7 @@ This `iframe` element is [inert][] because of another element that behaves as a [container document]: https://html.spec.whatwg.org/#bc-container-document 'HTML browsing context container document, 2020/12/18' [document]: https://html.spec.whatwg.org/multipage/dom.html#document 'HTML definition of document' [flattened tabindex-ordered focus navigation scope]: https://html.spec.whatwg.org/multipage/interaction.html#flattened-tabindex-ordered-focus-navigation-scope 'HTML - Living Standard, 2022/07/08' -[modal-dialog]: #modal-dialog 'Definition of Modal dialog' +[modal]: #modal-dialog 'Definition of Modal dialog' [nested browsing context]: https://html.spec.whatwg.org/#nested-browsing-context 'HTML nested browsing context, 2020/12/18' [owner document]: https://dom.spec.whatwg.org/#dom-node-ownerdocument 'DOM node owner document property, 2020/12/18' [sc211]: https://www.w3.org/TR/WCAG21/#keyboard 'WCAG 2.1 Success criterion 2.1.1 Keyboard' From b3ca4c8c7ea9b1fdb88a0fedb0ba4f2ce497626e Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Mon, 20 Mar 2023 13:54:55 +0100 Subject: [PATCH 09/20] Apply suggestions from code review Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com> --- .../iframe-not-focusable-has-no-interactive-content-akn7bn.md | 1 + pages/glossary/modal-dialog.md | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md index b0ce629aa6a..407cd4310bf 100755 --- a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md +++ b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md @@ -37,6 +37,7 @@ An element is contained in a [nested browsing con An `iframe` element is inert if: - it has an `inert` [attribute value][] of true; or +- one of its ancestor elements has an `inert` [attribute value][] of true; or - an element which is not the iframe itself and that is not [contained](#akn7bn:contain) in it behaves as a [modal][], making the iframe inoperable. ## Expectation diff --git a/pages/glossary/modal-dialog.md b/pages/glossary/modal-dialog.md index 0ac25e11820..e452226672e 100644 --- a/pages/glossary/modal-dialog.md +++ b/pages/glossary/modal-dialog.md @@ -9,7 +9,7 @@ input_aspects: - DOM tree --- -A modal dialog is a type of user interface element that appears on top of the main content of a [html web page][] or application and requires the user to take some action or make a decision before they can continue interacting with the program. +A modal dialog is an element which, until it is closed, prevents user interaction with any content on the web page that is not a descendant element of the modal. Visually, a modal often (but not necessarily) appears on top of all other content of the [html web page][] and visually darkens or otherwise obscures that other content. Modal dialogs are typically used to display important messages, prompts, or alerts that require the user's attention and prevent them from interacting with other parts of the page until they have addressed the issue at hand. They are "modal" because they create a temporary mode where the user is focused on the dialog and cannot interact with the rest of the page. From f51317861287256cd036b404b5f92ac6675ca647 Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Mon, 8 May 2023 09:53:26 +0200 Subject: [PATCH 10/20] Update iframe-not-focusable-has-no-interactive-content-akn7bn.md --- .../iframe-not-focusable-has-no-interactive-content-akn7bn.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md index 407cd4310bf..7913275346f 100755 --- a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md +++ b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md @@ -38,7 +38,7 @@ An element is contained in a [nested browsing con An `iframe` element is inert if: - it has an `inert` [attribute value][] of true; or - one of its ancestor elements has an `inert` [attribute value][] of true; or -- an element which is not the iframe itself and that is not [contained](#akn7bn:contain) in it behaves as a [modal][], making the iframe inoperable. +- it is [blocked by a modal](https://html.spec.whatwg.org/multipage/interaction.html#blocked-by-a-modal-dialog). ## Expectation From ed2b5aa89d0633398dce9271cbf75c4c2aeef5c5 Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Mon, 8 May 2023 10:02:17 +0200 Subject: [PATCH 11/20] Update and rename modal-dialog.md to inert.md --- pages/glossary/inert.md | 15 +++++++++++++++ pages/glossary/modal-dialog.md | 16 ---------------- 2 files changed, 15 insertions(+), 16 deletions(-) create mode 100644 pages/glossary/inert.md delete mode 100644 pages/glossary/modal-dialog.md diff --git a/pages/glossary/inert.md b/pages/glossary/inert.md new file mode 100644 index 00000000000..00f2eb0d940 --- /dev/null +++ b/pages/glossary/inert.md @@ -0,0 +1,15 @@ +--- +title: Inert +key: intert +unambiguous: true +objective: true +input_aspects: + - Accessibility tree + - CSS styling + - DOM tree +--- + +An [HTML or SVG element][] is inert if: +- it has an `inert` [attribute value][] of true; or +- one of its ancestor elements has an `inert` [attribute value][] of true; or +- it is [blocked by a modal](https://html.spec.whatwg.org/multipage/interaction.html#blocked-by-a-modal-dialog). diff --git a/pages/glossary/modal-dialog.md b/pages/glossary/modal-dialog.md deleted file mode 100644 index e452226672e..00000000000 --- a/pages/glossary/modal-dialog.md +++ /dev/null @@ -1,16 +0,0 @@ ---- -title: Modal dialog -key: modal-dialog -unambiguous: true -objective: true -input_aspects: - - Accessibility tree - - CSS styling - - DOM tree ---- - -A modal dialog is an element which, until it is closed, prevents user interaction with any content on the web page that is not a descendant element of the modal. Visually, a modal often (but not necessarily) appears on top of all other content of the [html web page][] and visually darkens or otherwise obscures that other content. - -Modal dialogs are typically used to display important messages, prompts, or alerts that require the user's attention and prevent them from interacting with other parts of the page until they have addressed the issue at hand. They are "modal" because they create a temporary mode where the user is focused on the dialog and cannot interact with the rest of the page. - -[html web page]: #web-page-html 'Definition of Web Page' From a35129714354f22e0a07029c230f93ee11de0432 Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Mon, 8 May 2023 10:03:32 +0200 Subject: [PATCH 12/20] Update iframe-not-focusable-has-no-interactive-content-akn7bn.md --- ...me-not-focusable-has-no-interactive-content-akn7bn.md | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md index 7913275346f..827595d333d 100755 --- a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md +++ b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md @@ -28,18 +28,13 @@ acknowledgments: ## Applicability -This rule applies to any `iframe` element that is not [inert](#akn7bn:inert) and that [contains](#akn7bn:contain) at least one element for which all the following are true: +This rule applies to any `iframe` element that is not [inert][] and that [contains](#akn7bn:contain) at least one element for which all the following are true: - the element is [visible][]; and - the element is part of the [sequential focus navigation order][] of the `iframe`'s [document][]. An element is contained in a [nested browsing context][] if its [owner document][] is the [container document][] of the [nested browsing context][]. -An `iframe` element is inert if: -- it has an `inert` [attribute value][] of true; or -- one of its ancestor elements has an `inert` [attribute value][] of true; or -- it is [blocked by a modal](https://html.spec.whatwg.org/multipage/interaction.html#blocked-by-a-modal-dialog). - ## Expectation The test target does not have a negative number as a `tabindex` [attribute value][]. @@ -152,7 +147,7 @@ This `iframe` element is [inert][] because of another element that behaves as a [container document]: https://html.spec.whatwg.org/#bc-container-document 'HTML browsing context container document, 2020/12/18' [document]: https://html.spec.whatwg.org/multipage/dom.html#document 'HTML definition of document' [flattened tabindex-ordered focus navigation scope]: https://html.spec.whatwg.org/multipage/interaction.html#flattened-tabindex-ordered-focus-navigation-scope 'HTML - Living Standard, 2022/07/08' -[modal]: #modal-dialog 'Definition of Modal dialog' +[inert]: #intert 'Definition of Inert' [nested browsing context]: https://html.spec.whatwg.org/#nested-browsing-context 'HTML nested browsing context, 2020/12/18' [owner document]: https://dom.spec.whatwg.org/#dom-node-ownerdocument 'DOM node owner document property, 2020/12/18' [sc211]: https://www.w3.org/TR/WCAG21/#keyboard 'WCAG 2.1 Success criterion 2.1.1 Keyboard' From aa22106e04bfc98c8d0eb10f45fcec94087017bf Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Mon, 8 May 2023 10:46:42 +0200 Subject: [PATCH 13/20] Update iframe-not-focusable-has-no-interactive-content-akn7bn.md --- ...sable-has-no-interactive-content-akn7bn.md | 31 ++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md index 827595d333d..93bf9c8f36f 100755 --- a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md +++ b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md @@ -132,7 +132,36 @@ This `iframe` element is [inert][] because of its own `inert` [attribute value][ #### Inapplicable Example 6 -This `iframe` element is [inert][] because of another element that behaves as a [modal][]. +Once "Privacy policy details" button is activated, the `iframe` element become [inert][] because of showModal() method that causes the `iframe` to be [blocked by a modal]. + +```html + +
+ +
+ +

Privacy Policy

+

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

+ +
+ +``` + +#### Inapplicable Example 7 + +This `iframe` element is [inert][] because it is [blocked by a modal]. ```html
From 40e33e2fbcbc293e6e56dfcd3a064d7ce8f2cfa6 Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Mon, 8 May 2023 10:53:20 +0200 Subject: [PATCH 14/20] Update spelling-ignore.yml --- __tests__/spelling-ignore.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/__tests__/spelling-ignore.yml b/__tests__/spelling-ignore.yml index f3078a8b641..b6ab2691017 100644 --- a/__tests__/spelling-ignore.yml +++ b/__tests__/spelling-ignore.yml @@ -204,6 +204,7 @@ - reflow - Viewport - dom-meta-content +- showModal # Unsure why the dictionary does not have these words - programmatically From 387b8df9c399840cb98503cf91d78de5d1e0fa33 Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Mon, 8 May 2023 10:56:48 +0200 Subject: [PATCH 15/20] Update iframe-not-focusable-has-no-interactive-content-akn7bn.md --- .../iframe-not-focusable-has-no-interactive-content-akn7bn.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md index 93bf9c8f36f..84dd9bf4be5 100755 --- a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md +++ b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md @@ -176,7 +176,7 @@ This `iframe` element is [inert][] because it is [blocked by a modal]. [container document]: https://html.spec.whatwg.org/#bc-container-document 'HTML browsing context container document, 2020/12/18' [document]: https://html.spec.whatwg.org/multipage/dom.html#document 'HTML definition of document' [flattened tabindex-ordered focus navigation scope]: https://html.spec.whatwg.org/multipage/interaction.html#flattened-tabindex-ordered-focus-navigation-scope 'HTML - Living Standard, 2022/07/08' -[inert]: #intert 'Definition of Inert' +[inert]: #inert 'Definition of Inert' [nested browsing context]: https://html.spec.whatwg.org/#nested-browsing-context 'HTML nested browsing context, 2020/12/18' [owner document]: https://dom.spec.whatwg.org/#dom-node-ownerdocument 'DOM node owner document property, 2020/12/18' [sc211]: https://www.w3.org/TR/WCAG21/#keyboard 'WCAG 2.1 Success criterion 2.1.1 Keyboard' From 32c564842dba5acf4e4d64353b7381b9b2f7ba65 Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Mon, 8 May 2023 10:56:59 +0200 Subject: [PATCH 16/20] Update inert.md --- pages/glossary/inert.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/glossary/inert.md b/pages/glossary/inert.md index 00f2eb0d940..6a5bb58fd6d 100644 --- a/pages/glossary/inert.md +++ b/pages/glossary/inert.md @@ -1,6 +1,6 @@ --- title: Inert -key: intert +key: inert unambiguous: true objective: true input_aspects: From f8fd582f92402963ce56d197cb8dfd202a3d95e6 Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Thu, 25 May 2023 12:07:53 +0200 Subject: [PATCH 17/20] Apply suggestions from code review Co-authored-by: Jean-Yves Moyen Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com> --- ...me-not-focusable-has-no-interactive-content-akn7bn.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md index 84dd9bf4be5..869922ed508 100755 --- a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md +++ b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md @@ -127,15 +127,15 @@ This `iframe` element contains a link that is not part of its [sequential focus This `iframe` element is [inert][] because of its own `inert` [attribute value][]. ```html - + ``` #### Inapplicable Example 6 -Once "Privacy policy details" button is activated, the `iframe` element become [inert][] because of showModal() method that causes the `iframe` to be [blocked by a modal]. +Once the "Privacy policy details" button is activated, the `iframe` element becomes [inert][] because of the showModal() method, which causes the `iframe` to be [blocked by a modal]. ```html - +
@@ -161,7 +161,7 @@ Once "Privacy policy details" button is activated, the `iframe` element become [ #### Inapplicable Example 7 -This `iframe` element is [inert][] because it is [blocked by a modal]. +This `iframe` element is [inert][] because it is [blocked by a modal][]. ```html
@@ -173,6 +173,7 @@ This `iframe` element is [inert][] because it is [blocked by a modal]. ``` [attribute value]: #attribute-value 'Definition of Attribute Value' +[blocked by a modal]: https://html.spec.whatwg.org/multipage/interaction.html#blocked-by-a-modal-dialog [container document]: https://html.spec.whatwg.org/#bc-container-document 'HTML browsing context container document, 2020/12/18' [document]: https://html.spec.whatwg.org/multipage/dom.html#document 'HTML definition of document' [flattened tabindex-ordered focus navigation scope]: https://html.spec.whatwg.org/multipage/interaction.html#flattened-tabindex-ordered-focus-navigation-scope 'HTML - Living Standard, 2022/07/08' From 95b23eeb1540fb8f34fe101c9ac2ba0ba5231850 Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Thu, 25 May 2023 12:13:49 +0200 Subject: [PATCH 18/20] Update iframe-not-focusable-has-no-interactive-content-akn7bn.md --- ...sable-has-no-interactive-content-akn7bn.md | 30 ++++--------------- 1 file changed, 5 insertions(+), 25 deletions(-) diff --git a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md index 869922ed508..42a5c64a053 100755 --- a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md +++ b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md @@ -144,34 +144,14 @@ Once the "Privacy policy details" button is activated, the `iframe` element beco

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

- ``` -#### Inapplicable Example 7 - -This `iframe` element is [inert][] because it is [blocked by a modal][]. - -```html -
-
- -

Hello World!

-
- -``` - [attribute value]: #attribute-value 'Definition of Attribute Value' [blocked by a modal]: https://html.spec.whatwg.org/multipage/interaction.html#blocked-by-a-modal-dialog [container document]: https://html.spec.whatwg.org/#bc-container-document 'HTML browsing context container document, 2020/12/18' From 2aba16dd1efaa38067159c6dd0e98d5ce0b5afcb Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Thu, 25 May 2023 13:07:47 +0200 Subject: [PATCH 19/20] Update inert.md --- pages/glossary/inert.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pages/glossary/inert.md b/pages/glossary/inert.md index 6a5bb58fd6d..42307a76d01 100644 --- a/pages/glossary/inert.md +++ b/pages/glossary/inert.md @@ -12,4 +12,8 @@ input_aspects: An [HTML or SVG element][] is inert if: - it has an `inert` [attribute value][] of true; or - one of its ancestor elements has an `inert` [attribute value][] of true; or -- it is [blocked by a modal](https://html.spec.whatwg.org/multipage/interaction.html#blocked-by-a-modal-dialog). +- it is [blocked by a modal][]. + +[HTML or SVG element]: #namespaced-element 'Definition of HTML or SVG element' +[attribute value]: #attribute-value 'Definition of Attribute value' +[blocked by a modal]: https://html.spec.whatwg.org/multipage/interaction.html#blocked-by-a-modal-dialog From 3d655f4a788e5760860029de14e0a48f0e01604f Mon Sep 17 00:00:00 2001 From: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com> Date: Thu, 31 Aug 2023 11:30:42 +0200 Subject: [PATCH 20/20] Apply suggestions from code review Co-authored-by: Wilco Fiers --- ...sable-has-no-interactive-content-akn7bn.md | 22 ++++++++++--------- pages/glossary/inert.md | 3 ++- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md index 42a5c64a053..82a1b7ee9c3 100755 --- a/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md +++ b/_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md @@ -135,20 +135,22 @@ This `iframe` element is [inert][] because of its own `inert` [attribute value][ Once the "Privacy policy details" button is activated, the `iframe` element becomes [inert][] because of the showModal() method, which causes the `iframe` to be [blocked by a modal]. ```html - +
- +
-

Privacy Policy

-

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

- +

Privacy Policy

+

We store no data.

+
- ``` diff --git a/pages/glossary/inert.md b/pages/glossary/inert.md index 42307a76d01..a3ab8197034 100644 --- a/pages/glossary/inert.md +++ b/pages/glossary/inert.md @@ -11,9 +11,10 @@ input_aspects: An [HTML or SVG element][] is inert if: - it has an `inert` [attribute value][] of true; or -- one of its ancestor elements has an `inert` [attribute value][] of true; or +- one of its ancestor elements in the [flat tree][] has an `inert` [attribute value][] of true; or - it is [blocked by a modal][]. [HTML or SVG element]: #namespaced-element 'Definition of HTML or SVG element' [attribute value]: #attribute-value 'Definition of Attribute value' [blocked by a modal]: https://html.spec.whatwg.org/multipage/interaction.html#blocked-by-a-modal-dialog +[flat tree]: https://drafts.csswg.org/css-scoping/#flat-tree 'Definition of flat tree'