Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text spacing rewrite #1923
Text spacing rewrite #1923
Changes from 21 commits
6ac7c5c
453902b
e8f7c9e
77be6e9
b9a6561
dc1d399
8a0e96c
27a16ab
152e445
cb09dc9
27ce954
840a39c
f30eb45
8afae38
090aa68
48b48eb
be908ce
f3f052e
2e983f5
d7da031
b9f5c61
d1d1c07
08b8fde
7410673
32eb79c
8dd55d8
b2af34e
7815582
a4456f3
c087368
5ced4b4
f82a0c4
8d6fcd7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the computed value
important
?Or is it the declaration of the
letter-spacing
property that isimportant
?The
important
declaration influences how the computed value is obtained, but I'm not sure we can say the computed value isimportant
....There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. We do need to somehow look at the computed value due to Inapplicable Example 8, where the
inherit !important
declaration is important but we don't care because the computed value is the inherited one, coming from a non-important declaration and thus can be overwritten.I do agree that only declarations seems to be important 🙈
Given that this wording is already present in the current rule (first bullet in Expectation + Passed Example 7), I suggest we treat that in another Issue/PR: #2002
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a comment on #2002 on a way to deal with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think font-size is needed on this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I prefer keeping it rather than relying on default
font-size
, especially given that the example is about changing thefont-size
between the definition ofletter-spacing
and the text.Otherwise, we might need a somewhat clumsy description to point out the rewrite (e.g. saying that
2px
is not big enough for the default16px
but that is OK because the actual one is10px
).