Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Orientation of the page is not restricted using CSS transform property" [b33eff]: Failed example 3 doesn't show on screen #1782

Closed
Jym77 opened this issue Jan 18, 2022 · 2 comments · Fixed by #2109
Assignees

Comments

@Jym77
Copy link
Collaborator

Jym77 commented Jan 18, 2022

When looking at Failed example 3 of rule Orientation of the page is not restricted using CSS transform property, in landscape mode on a wide screen, the page looks empty.
This is likely due to the wide body element being rotated on its rightmost corners and thus the small text on the left side got pushed off-screen at the top.

We should likely make sure there actually is something visible on both orientations.
(other examples of this rule might suffer from similar problems on either orientation, I haven't double checked all of them).

Screenshot of Failed Example 3, showing the rotated body element with its beginning pushed off-screen

@WilcoFiers
Copy link
Member

This also seems to happen to inapplicable example 3 and 4.

@tombrunet
Copy link
Collaborator

@WilcoFiers Created a PR. I did not touch inapplicable 3 because it's hidden intentionally (It's not applicable because it's display none and therefore not visible).

It was a little trickier than first thought because, while the rotation is fixed, the distance the text moves depends on the size of the box rotating (browser width/height). I think the CSS I added should limit this enough to at least let the test cases do what they're supposed to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants