New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several SolHint issues raised by GH Actions #263

Open

james-a-morris opened this issue Mar 20, 2023 · 4 comments

Assignees

Contributor

james-a-morris commented Mar 20, 2023

There are several unchecked issues that Solhint has raised.

Here is an example of a diff that contains these issues: https://github.com/across-protocol/contracts-v2/pull/262/files#

The following actions script has raised these issues: https://github.com/across-protocol/contracts-v2/actions/runs/4469185546/jobs/7850936946?pr=262

The files that these lint issues affect are:

contracts/chain-adapters/Arbitrum_Adapter.sol
contracts/chain-adapters/Arbitrum_SendTokensAdapter.sol
contracts/chain-adapters/Succinct_Adapter.sol
contracts/external/WETH9.sol

james-a-morris assigned nicholaspai, mrice32, dohaki, amateima and pxrl

ogubuikeAlex commented Jul 31, 2023

Hey @james-a-morris
Can I work on this?

Contributor Author

james-a-morris commented Oct 14, 2023

Hey @james-a-morris

Can I work on this?

Hello and sorry for the late reply! You're always welcome to contribute to Across. 🙂

If you're still interested, feel free to put up a PR. I promise we have a much faster turn around on responding to pull requests 😅

ogubuikeAlex commented Oct 15, 2023

Great

Narendra-Reddy1 commented Aug 15, 2024

Hey @king-Alex-d-great , are still working on this particular issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment