Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting custom resources that don't have a podSpecTemplate #137

Open
drmorr0 opened this issue Sep 23, 2024 Discussed in #135 · 1 comment
Open

Supporting custom resources that don't have a podSpecTemplate #137

drmorr0 opened this issue Sep 23, 2024 Discussed in #135 · 1 comment
Labels
bug Something isn't working sk-driver Issues with the Simulation runner sk-tracer Issues with the Kubernetes tracer

Comments

@drmorr0
Copy link
Contributor

drmorr0 commented Sep 23, 2024

Discussed in #135

Originally posted by shravan-achar September 18, 2024
Some custom resources such as Spark Applications (https://github.com/kubeflow/spark-operator/blob/master/config/crd/bases/sparkoperator.k8s.io_sparkapplications.yaml) which do create pods but do not expose a full podSpec template in its custom resource definition.

Potentially, the tracer can watch pods and track ownership based on labels/annotations instead of the owner reference field.

This seems like a bug that we should fix.

@drmorr0 drmorr0 added bug Something isn't working sk-tracer Issues with the Kubernetes tracer sk-driver Issues with the Simulation runner labels Sep 23, 2024
@drmorr0
Copy link
Contributor Author

drmorr0 commented Oct 9, 2024

#143 is the first step towards supporting this; we no longer require the podSpecTemplatePath in the tracer config. However I think this may still not completely work in the simulated environment; I will need to do some testing and see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sk-driver Issues with the Simulation runner sk-tracer Issues with the Kubernetes tracer
Projects
None yet
Development

No branches or pull requests

1 participant