Guzzle 7 Breaks Run-server Command #4655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #4656
We noticed that the run-server command constantly fails on our Travis build after upgrading to Drupal 10. After looking into the code, we found that the
exceptionsused in thecheckUrlmethod is no longer respected in Guzzle 7 and causing a client error to be thrown when curl returns a 404 response .The option was deprecated in Guzzle 6 and was removed in 7 according to this PR guzzle/guzzle#2464 (I don't see the option being marked deprecated anywhere)
Proposed changes
Switch to use the new option
http_errors. The option was introduced in Guzzle 6, so it should be safe to use without changing anything in thecomposer.jsonfile as Guzzle 6 was the minimum version required by Drupal 9.Testing steps
blt tests:server:start -vvvv.