Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behat tests giving timeout error on lando. #4328

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Conversation

nileshlohar
Copy link
Contributor

@nileshlohar nileshlohar commented Jan 29, 2021

Motivation

https://support.acquia.com/hc/en-us/articles/360047166273-Configuring-Acquia-BLT-with-Lando

This resolves the "Chrome timeouts" issue on behat test while running on lando.

Changes

Add --no-sandbox option to launchChrome function.

Alternatives considered

We might not able merge this as it can affect everyone but, just adding ready patch here for all lando users facing same issue.

@nileshlohar nileshlohar changed the title Adding --no-sandbox option to launchChrome. Behat tests giving timeout error on lando. Jan 29, 2021
@danepowell danepowell added the Enhancement A feature or feature request label Jan 29, 2021
@danepowell
Copy link
Contributor

Thanks. I think there is precedent for using the no-sandbox parameter (in ADS and Pipelines) so I'm fine including it here as well for all users. Since it's a dedicated test process I don't think the security implications are significant.

@danepowell danepowell merged commit bc1ea73 into acquia:main Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants