Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving dev desktop settings.php compatibility. #37

Merged
merged 4 commits into from
May 6, 2016
Merged

Improving dev desktop settings.php compatibility. #37

merged 4 commits into from
May 6, 2016

Conversation

grasmash
Copy link
Contributor

@grasmash grasmash commented May 5, 2016

No description provided.

geerlingguy
geerlingguy reviewed May 5, 2016
View reviewed changes
template/project.yml
# This will determine the the directory name of the new repository.
acquia_subname: 'bolted8'
# Dev Desktop users: this should match your local site name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This docs line makes it look like this configuration directive would be important for Dev Desktop users but might not be as important for others... is there a way this could be worded better to match what it is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any wording you have in mind? :p

@kylebrowning
Copy link
Contributor

I have tested this, thank you so much for looking into, it works great.

@grasmash grasmash merged commit e5a0416 into acquia:8.x May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grasmash @kylebrowning @geerlingguy