Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-221: Adds a frontend:setup task and also passthru for target-hooks #259

Closed
wants to merge 1 commit into from

Conversation

sarahjean
Copy link

Relates to #221

<project name="frontend" default="frontend:install">
<project name="frontend" default="frontend:setup">

<target name="frontend:setup" description="Uses project.yml hooks to run custom defined commands to setup front end dependencies for frontend:build.">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update description.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grasmash It is different, is "Uses project.yml hooks to run custom defined commands to setup front end dependencies for frontend:build." confusing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I guess I see what you did there. The frontend:build reference confused me initially.

@grasmash
Copy link
Contributor

grasmash commented Aug 4, 2016

Nothing appears to actually trigger frontend:setup. Should it be a dependency of frontend:build?

@sarahjean
Copy link
Author

@grasmash The idea is that frontend:build can be run without triggering frontend:setup and would therefore run faster since it doesn't have to do npm install or whatever. It would make more sense to trigger it for local:setup and/or for a Travis build but not have it run every time you do a frontend:build.

@grasmash
Copy link
Contributor

grasmash commented Aug 15, 2016

In that case, I'd introduce a frontend target that depends on frontend:install and frontend:build. setup can then depend on frontend.

@grasmash
Copy link
Contributor

Closing in favor of #291

@grasmash grasmash closed this Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants