Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and update readme/creating-new-project.md #2401

Merged
merged 2 commits into from
Jan 3, 2018
Merged

Fix and update readme/creating-new-project.md #2401

merged 2 commits into from
Jan 3, 2018

Conversation

TravisCarden
Copy link
Contributor

@TravisCarden TravisCarden commented Jan 2, 2018 •
edited
Loading

readme/creating-new-project.md has a few issues:

  1. It's missing a composer install. Following the steps exactly as written today will result in an error.
  2. The list formatting is broken.
  3. There's a minor grammar nerd issue. 😛

@grasmash
Copy link
Contributor

grasmash commented Jan 2, 2018

composer install should not be necessary? I think you had to run it to workaround #2378. The fix for that needs to be released.

@grasmash
Copy link
Contributor

grasmash commented Jan 2, 2018

Fix released. composer install should not be necessary now.

@TravisCarden
Copy link
Contributor Author

Thanks, @grasmash. I've removed that commit.

@grasmash grasmash merged commit b3d461d into acquia:9.1.x Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TravisCarden @grasmash