Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX-5102: Config Split Recipe Issues #4500

Closed
mikemadison13 opened this issue Apr 12, 2022 · 0 comments
Closed

DX-5102: Config Split Recipe Issues #4500

mikemadison13 opened this issue Apr 12, 2022 · 0 comments
Labels
Bug Something isn't working

Comments

@mikemadison13
Copy link
Contributor

Describe the bug
There are a number of issues with the current Config Split recipe:

  1. the config splits are set to "true" by default (when they should be disabled by default). Splits should be enabled in the proper contexts by BLT or other code
  2. the way the recipe generates the splits can cause CI failures, as it does not place the .htaccess file in the config directories
  3. the config split recipe does not add config split / config filter as an enabled module. so, again, it can cause config import problems as it stands because it doesn't actually enable the modules. this has been resolved in the davidtrainer/blt-site-studio plugin and we should replicate that logic here.
@mikemadison13 mikemadison13 added the Bug Something isn't working label Apr 12, 2022
@github-actions github-actions bot changed the title Config Split Recipe Issues DX-5102: Config Split Recipe Issues Apr 12, 2022
mikemadison13 pushed a commit to mikemadison13/blt that referenced this issue Apr 12, 2022
mikemadison13 pushed a commit to mikemadison13/blt that referenced this issue Apr 12, 2022
mikemadison13 pushed a commit to mikemadison13/blt that referenced this issue Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant