Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that SimpleSAML on PHP 7 should only use database session storage #1857

Closed
typhonius opened this issue Jul 31, 2017 · 3 comments
Closed
Labels
Enhancement A feature or feature request

Comments

@typhonius
Copy link
Contributor

typhonius commented Jul 31, 2017

As discovered here: simplesamlphp/simplesamlphp#395 the SimpleSAMLphp library doesn't integrate well with memcache on PHP7.

The reason for this is that it assumes the existance of the Memcache class. Memcache is totally not ready for showtime on PHP7, whereas its sister Memcached is. Currently, Memcached is not supported by SimpleSAMLphp.

Acquia does not have the Memcache class, which causes fatal errors if memcache is selected as a session storage when using PHP > 7.

Are we best to default to database in the simplesaml template or keep the defaults and write some documentation on the simplesaml page to ensure unwitting teams don't get caught short?

@grasmash grasmash added Enhancement A feature or feature request documentation labels Jul 31, 2017
@greylabel
Copy link
Contributor

Just ran into this issue as well updating our ACE environments to PHP7 -- default to database in the simplesaml template seems reasonable.

@grasmash
Copy link
Contributor

grasmash commented Aug 2, 2017

You could even detect PHP version and set accordingly. Otherwise, "default to database in the simplesaml template seems reasonable" to me too.

@grasmash
Copy link
Contributor

grasmash commented Aug 2, 2017

@typhonius Would you mind submitting PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

No branches or pull requests

3 participants