Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False SyntaxError for class methods with name "delete" and modifier "async" or "static" #1027

Closed
OpportunityLiu opened this issue Apr 24, 2021 · 3 comments

Comments

@OpportunityLiu
Copy link

acorn version 8.2.0

https://runkit.com/embed/u3sw3r2rj517

works fine in 8.1.1

@marijnh
Copy link
Member

marijnh commented Apr 24, 2021

Thanks for reporting that. 8.2.1 should behave better.

@mysticatea Could you take a quick look at db13859 and verify that it makes sense to you?

@mysticatea
Copy link
Contributor

Hi. I'm sorry for that bug.

Could you take a quick look at db13859 and verify that it makes sense to you?

Looks good to me.

Because the isClassElementNameStart method is used in acorn-loose (/acorn-loose/src/statement.js#L400) as well, maybe releasing acorn-loose is nice.

@marijnh
Copy link
Member

marijnh commented Apr 27, 2021

I don't think that's necessary—upgrading acorn will give you the proper method in acorn-loose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants