-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_isIPv4 vulnerability based on existing files in /acme.sh #4971
Comments
Please upgrade to the latest code and try again first. Maybe it's already fixed. |
Alternatively, this might be a less vulnerable function, POSIX safe, and only return 0 when a valid IPv4 address is provided (the current function returns 0 with "1" or "1.1"):
|
This was referenced Jan 30, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
https://github.com/acmesh-official/acme.sh/blob/master/acme.sh#L4266
Recommend pulling out the 'not all number' check like this:
The text was updated successfully, but these errors were encountered: