Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split the code into components #1

Open
3 tasks done
ackzell opened this issue Apr 19, 2020 · 1 comment
Open
3 tasks done

Split the code into components #1

ackzell opened this issue Apr 19, 2020 · 1 comment
Milestone
MVP 1.0

Comments

@ackzell
Copy link
Owner

ackzell commented Apr 19, 2020 •
edited
Loading

  • Elapsed time while recording
  • Recordings list
  • Figure out if more needed
ackzell added a commit that referenced this issue Apr 19, 2020
@ackzell
#1 Cleaning up the code on the main component. Abstracting more logic…
bca3017 
… into the timer component.
ackzell added a commit that referenced this issue Apr 20, 2020
@ackzell
#1 leaving out the https part, not needed on deploy
21b5c0f
ackzell added a commit that referenced this issue Apr 24, 2020
@ackzell
#1 #2 Abstracting the recording component.
efe05dc
ackzell added a commit that referenced this issue Apr 24, 2020
@ackzell
#1 #2 Working on the recording component.
77634f6
ackzell added a commit that referenced this issue Apr 25, 2020
@ackzell
#2 #1 Working on the local download, working on removing from list.
f60378f
ackzell added a commit that referenced this issue Apr 25, 2020
@ackzell
Merge pull request #9 from ackzell/2-recording-component
e479d85 
#1 #2 Abstracting the recording component.
@ackzell ackzell added this to the MVP 1.0 milestone Apr 26, 2020
@ackzell ackzell closed this as completed Apr 26, 2020
ackzell added a commit that referenced this issue Apr 30, 2020
@ackzell
#11 #1 Cleaning up the code. Working on the selection logic.
afad766
@ackzell
Copy link
Owner Author

ackzell commented May 9, 2020

The index.vue has a lot of logic that has to do with the recording and uploading at the same time.

We can probably break apart at least the upload and leave the bottom card as a separate component.

Try and see if we can also have the recording logic in its own component. Either:

  • the list of recordings would live in it's own card and we have 3 cards instead of 2
  • or the list is part of the form to upload

@ackzell ackzell reopened this May 9, 2020
ackzell added a commit that referenced this issue May 23, 2020
@ackzell
#1 Working on the flow. Creating a static height card to hold the rec…
3261eae 
…ordings and adding a message to it for when it is empty.
ackzell added a commit that referenced this issue May 23, 2020
@ackzell
#1 Branding.
bbb345f
ackzell added a commit that referenced this issue May 23, 2020
@ackzell
#1 One can't just add transitions to list groups.
328b352
ackzell added a commit that referenced this issue May 25, 2020
@ackzell
#1 Adding some transitions.
f4e4992
ackzell added a commit that referenced this issue May 30, 2020
@ackzell
#1 Catching exception.
23ec813
ackzell added a commit that referenced this issue May 30, 2020
@ackzell
#1 Catching exception.
8bfae83
ackzell added a commit that referenced this issue May 30, 2020
@ackzell
#1 Canceling the recording. Attempting to prevent the leakage further…
74d4738 
…. (and actually using the API *facepalm*)
ackzell added a commit that referenced this issue Jun 3, 2020
@ackzell
#1 Attempting to address some observations made by Diego.
7ed9eff
ackzell added a commit that referenced this issue Jun 3, 2020
@ackzell
#1 Making clear that there is a recording selected and it wil be sent.
266449e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MVP 1.0
Development

No branches or pull requests
1 participant
@ackzell