LSD v0.1.0-beta - Date range picker #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongomez
changed the title
jongomez
force-pushed
the
topic-implement-date-range-picker
branch
from
5a92c63 to
ce2392a
Compare
jongomez
commented
Oct 9, 2023
|
This comes from an external hook we're using, I don't think we're doing anything on our side. I'll try to fix this though |
jongomez
force-pushed
the
topic-implement-date-range-picker
branch
from
f875ba8 to
1200b33
Compare
jongomez
commented
Oct 17, 2023
Comment on lines
-28
to
-40
| const { onClick, onKeyDown, onMouseEnter, tabIndex } = useDay({ | ||
| date, | ||
| focusedDate, | ||
| isDateFocused, | ||
| isDateSelected, | ||
| isDateHovered, | ||
| isDateBlocked, | ||
| isFirstOrLastSelectedDate, | ||
| onDateFocus, | ||
| onDateSelect, | ||
| onDateHover, | ||
| dayRef, | ||
| }) |
There was a problem hiding this comment.
One of the requests from @amirhouieh was:
Is there a specific logic/routine implemented upon hover? the cursor seems shaking and unstable when hovering over the day numbers ?
I believe the culprit was this useDay hook - it adds some hovering logic as we can see from its source code. I removed this hook because as far as I can tell the hovering logic is not needed. If we do need it sometime in the future, it should be easy to implement it ourselves.
jeangovil
previously approved these changes
Oct 18, 2023
jongomez
force-pushed
the
topic-implement-date-range-picker
branch
from
bf479a1 to
32d95a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a date range picker component.
Figma link
Based on Jinho's work from this PR.