Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement date picker components #19

Merged
merged 14 commits into from
Oct 5, 2023
Merged

Conversation

jinhojang6
Copy link
Contributor

@jinhojang6 jinhojang6 commented Feb 27, 2023

@jinhojang6 jinhojang6 changed the base branch from main to batch-1 February 27, 2023 18:02
@jinhojang6 jinhojang6 force-pushed the topic-implement-date-picker branch from c6c192d to 22319ea Compare March 16, 2023 18:48
@jinhojang6 jinhojang6 requested a review from jeangovil March 16, 2023 18:49
@jinhojang6 jinhojang6 force-pushed the topic-implement-date-picker branch 3 times, most recently from 4da2ec7 to e7531ad Compare March 16, 2023 19:51
@jinhojang6 jinhojang6 changed the title Implement date picker Implement date picker components Mar 16, 2023
@amirhouieh
Copy link

amirhouieh commented Mar 17, 2023

@jinhojang6 had a quick look, great work in the time, and some notes on the UI and UX side of the implementation

@jinhojang6 jinhojang6 force-pushed the topic-implement-date-picker branch from d2af9ec to a1e4da5 Compare March 20, 2023 16:28
@jinhojang6
Copy link
Contributor Author

Updated the feedback based on the feedback of both.

On top of this,

  1. I tried many ways but it seems that input[type=date] doesn't support focusing on a specific date format among yyyy, mm, dd
    Reference: https://stackoverflow.com/questions/30085591/focus-month-or-year-of-html5-inputtype-date

Do you have any suggestions?

  1. Can you please help implement the font family? @jeangovil

@jeangovil
Copy link
Contributor

jeangovil commented Mar 21, 2023

@jinhojang6, thank you for the updates. I've added support for font-family and merged it with this branch, here's how you can change the font face type on Storybook:
image

Could you please fix the controlled versions of DatePicker and the Calendar? If a value is passed to the component and the onChange callback is left unset, then the value should not change through interactions with the UI.

@jinhojang6 jinhojang6 force-pushed the topic-implement-date-picker branch from 705c48a to 7c6f8f3 Compare March 21, 2023 13:56
@jeangovil jeangovil changed the base branch from batch-1 to main April 14, 2023 00:01
@jinhojang6 jinhojang6 added this to the Beta milestone Sep 26, 2023
This was referenced Sep 27, 2023
@jongomez jongomez force-pushed the topic-implement-date-picker branch from df620df to 2a52be4 Compare September 28, 2023 09:43
@jongomez
Copy link
Contributor

jongomez commented Sep 28, 2023

Edit: re-requested reviews. Updated styles and fixed a few issues.

Storybook link

@jongomez jongomez requested review from jeangovil and amirhouieh and removed request for jeangovil and amirhouieh September 28, 2023 12:33
@jongomez jongomez marked this pull request as draft September 28, 2023 15:33
@jongomez jongomez marked this pull request as ready for review September 29, 2023 09:10
@jongomez jongomez mentioned this pull request Sep 29, 2023
@jongomez jongomez force-pushed the topic-implement-date-picker branch from b18b8c3 to e30959a Compare October 5, 2023 12:44
@jongomez jongomez merged commit 261b96f into main Oct 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Beta
Development

Successfully merging this pull request may close these issues.

4 participants