-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement date picker components #19
Conversation
c6c192d
to
22319ea
Compare
4da2ec7
to
e7531ad
Compare
@jinhojang6 had a quick look, great work in the time, and some notes on the UI and UX side of the implementation
|
d2af9ec
to
a1e4da5
Compare
Updated the feedback based on the feedback of both. On top of this,
Do you have any suggestions?
|
@jinhojang6, thank you for the updates. I've added support for font-family and merged it with this branch, here's how you can change the font face type on Storybook: Could you please fix the controlled versions of |
705c48a
to
7c6f8f3
Compare
packages/lsd-react/src/components/DatePicker/DatePicker.styles.ts
Outdated
Show resolved
Hide resolved
df620df
to
2a52be4
Compare
Edit: re-requested reviews. Updated styles and fixed a few issues. |
Prevent clicking on disabled calendar days from changing the date.
b18b8c3
to
e30959a
Compare
Figma: https://www.figma.com/file/YOfkPWwdFicw6dHXNaSSwh/LSD-%E2%80%93-Radical?node-id=1616-42189&t=ZacdEc1luPHQw7yw-0
Storybook: https://63e4f71c39dc65c5c703c1e8-udpmwlhsaj.chromatic.com/?path=/story/datepicker--root&globals=backgrounds.value:!rgb(255,255,255)