fix - remote repo scan with config only option generates panic #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #948 +/- ##
=======================================
Coverage 78.81% 78.81%
=======================================
Files 216 216
Lines 5272 5272
=======================================
Hits 4155 4155
Misses 864 864
Partials 253 253
|
Rchanger
approved these changes
Jul 26, 2021
kanchwala-yusuf
approved these changes
Jul 26, 2021
cesar-rodriguez
pushed a commit
to Rchanger/terrascan
that referenced
this pull request
Aug 2, 2021
cesar-rodriguez
pushed a commit
that referenced
this pull request
Aug 5, 2021
* add: support for using already downloaded remote module from terraform cache * code nits: added comments * added e2e test for --use-terraform-cache flag * added unit test for newly added function * adds usage of --non-recursive and --use-terraform-cache in docs * Update run.go Fixes typo * code nits: type fix and code implementation changes * Adds: use of map to pass scan options to IaC provider - changed interface method signature to accept map parameter so that we can pass any no of flag to implementer without changing method signature. - moved the non recursive flag to map to achieve uniformity - In terraform used switch for flag identification so that in future new flag or option provided just need to add another case rather than if/else * Update README.md (#945) updated all links . * update helm chart progress checklist (#943) We doSupport TLS certificate/key in existing secrets * Update mkdocs-material from 7.1.11 to 7.2.0 (#939) * fix - config only option used with remote repo scan generates panic (#948) * Update mkdocs-material from 7.2.0 to 7.2.1 (#947) * Adds Terrascan pre-commit (#953) Adds pre-commit integration for Terrascan Co-authored-by: mihirhasan <[email protected]> * Update mkdocs-material from 7.2.1 to 7.2.2 (#954) * terraform cache use with non recursive dir scan - modified code to make scan directory non recursively when --use-terraform-cache is used. - modified scan command flag description and docs accordingly. * fixes: docker implementer for map parameter - modified docker LoadIacDir and LoadIacFile method to accept map parameter - registered docker as cloud provider so that docker policies will be used from '.terrascan' folder * code nits: removed unwanted if condtions and added error logs Co-authored-by: Cesar Rodriguez <[email protected]> Co-authored-by: Sangam Biradar <[email protected]> Co-authored-by: Devang Gaur <[email protected]> Co-authored-by: pyup.io bot <[email protected]> Co-authored-by: Pankaj Patil <[email protected]> Co-authored-by: mihirhasan <[email protected]> Co-authored-by: mihirhasan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.