Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s policies refactor #879

Merged
merged 8 commits into from
Jun 30, 2021
Merged

k8s policies refactor #879

merged 8 commits into from
Jun 30, 2021

Conversation

gaurav-gogia
Copy link
Contributor

  • remove duplicate policies
  • update existing policies

@gaurav-gogia gaurav-gogia self-assigned this Jun 22, 2021
@gaurav-gogia gaurav-gogia added the policy Issue concerning policy maintainers. label Jun 22, 2021
@codecov
Copy link

codecov bot commented Jun 22, 2021 •
edited
Loading

Codecov Report

Merging #879 (ae546c0) into master (9f050b3) will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #879      +/-   ##
==========================================
+ Coverage   78.20%   78.41%   +0.20%     
==========================================
  Files         165      168       +3     
  Lines        4405     4470      +65     
==========================================
+ Hits         3445     3505      +60     
- Misses        739      741       +2     
- Partials      221      224       +3
Impacted Files Coverage Δ
pkg/writer/sarif.go 82.97% <0.00%> (-11.90%) ⬇️
pkg/utils/dir.go 81.81% <0.00%> (ø)
pkg/mapper/iac-providers/cft/mapper.go
pkg/mapper/iac-providers/cft/config/s3-bucket.go 81.81% <0.00%> (ø)
...apper/iac-providers/cft/config/s3-bucket-policy.go 100.00% <0.00%> (ø)
pkg/utils/file.go 33.33% <0.00%> (ø)
pkg/mapper/iac-providers/cft/cft.go 94.91% <0.00%> (ø)
pkg/utils/json.go 69.69% <0.00%> (+0.94%) ⬆️
pkg/iac-providers/cft/v1/load-file.go 80.76% <0.00%> (+24.62%) ⬆️

@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@devang-gaur devang-gaur changed the title mod k8s policies to improve parity with siac k8s policies refactor Jun 29, 2021
shreyas-phansalkar-189
shreyas-phansalkar-189 approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@shreyas-phansalkar-189 shreyas-phansalkar-189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@gaurav-gogia gaurav-gogia merged commit 2fdc14d into tenable:master Jun 30, 2021
@gaurav-gogia gaurav-gogia deleted the bugfix/k8s_policies branch June 30, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-phansalkar-189 shreyas-phansalkar-189 shreyas-phansalkar-189 approved these changes

@harkirat22 harkirat22 Awaiting requested review from harkirat22

Assignees

@gaurav-gogia gaurav-gogia

Labels
policy Issue concerning policy maintainers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaurav-gogia @harkirat22 @shreyas-phansalkar-189